Skip to content

[AUD-027] [INFO] LibParseCharSlow carries zero NatSpec while sibling LibParseDecimalSlow documents its oracle role #97

Description

@thedavidmeister

Whole-repo audit 2026-08-24 at commit 3e76bab (audit skill 0.35.0). Pass 2 status: ledgered (audit/mutation-test-scans.json, scan of 2026-08-24T08:55:39Z at 35496d8).

test/lib/parse/LibParseCharSlow.sol:5-32

LibParseCharSlow has zero natspec — no library @title/@notice and no docs on skipMaskSlow/isMaskSlow — while its direct sibling LibParseDecimalSlow documents both its role as a spec-derived reference implementation and each function's params/returns. Nothing states that these are naive oracles for LibParseChar written independently of the production assembly.

Proposed fix

Add to test/lib/parse/LibParseCharSlow.sol before line 5:

/// @title LibParseCharSlow
/// @notice Naive reference implementations of the `LibParseChar` contract,
/// written with explicit bounds branches rather than the production
/// branchless assembly, for equivalence testing.

plus one-line docs on each function mirroring LibParseDecimalSlow's style.

Metadata

Metadata

Labels

auditAudit findinginfoAudit findingpass3Audit finding

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions