Skip to content

[AUD-024] [INFO] LibParseChar and LibParseDecimal lack library-level @title/@notice #94

Description

@thedavidmeister

Whole-repo audit 2026-08-24 at commit 3e76bab (audit skill 0.35.0). Pass 2 status: ledgered (audit/mutation-test-scans.json, scan of 2026-08-24T08:55:39Z at 35496d8).

src/lib/parse/LibParseChar.sol:5

Neither LibParseChar (src/lib/parse/LibParseChar.sol line 5) nor LibParseDecimal (src/lib/parse/LibParseDecimal.sol line 14) carries library-level @title/@notice natspec, while LibConformString and even the test-only LibParseDecimalSlow do — the two core parsing libraries are the only undocumented library declarations in the repo.

Proposed fix

Add to src/lib/parse/LibParseChar.sol before line 5:

/// @title LibParseChar
/// @notice Branchless single-character membership tests against uint256
/// character masks over raw memory cursors.

And to src/lib/parse/LibParseDecimal.sol before line 14:

/// @title LibParseDecimal
/// @notice Decimal ASCII to integer conversion over raw memory regions,
/// reporting failures as bare error selectors instead of reverting.

Metadata

Metadata

Labels

auditAudit findinginfoAudit findingpass3Audit finding

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions