Repository navigation
Commit e5850df
committed
fix: revert 60 format-language keys back to string-only
PR #14773 widened these keys to anyOf: [string, null] to stop a YAML
no-value key (parses as null) from failing schema validation. That
traded a caught typo for a worse failure: the label then renders as an
empty string instead of falling back to its shipped default, the same
symptom #14813 fixes for its five navigation-*-label keys.
Nothing in _language.yml or the test suite relies on null clearing a
shipped default, and translationsForLang's null-pass-through clause
exists for custom/extension keys, not these 60 shipped ones, so the
anyOf addition added no expressive power for them. Empty string
remains the supported way to clear a shipped default.
The 09/07 schema-files fixture asserting null validates has moved to
tests/docs/schema-validation/ with a dedicated test that now asserts
the opposite; that fixture's directory no longer matches
schema-files.test.ts's always-expect-success glob.1 parent 5437792 commit e5850df
11 files changed
Lines changed: 474 additions & 2054 deletions
File tree
- llm-docs
- src/resources
- editor/tools
- yaml
- schema
- types
- zod
- tests
- docs/schema-validation
- unit/schema-validation
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
242 | 242 | | |
243 | 243 | | |
244 | 244 | | |
| 245 | + | |
245 | 246 | | |
246 | 247 | | |
247 | 248 | | |
| |||
0 commit comments