Skip to content

Commit e57fe4a

Browse files
authored
DataTable: suppress selection announcements while hidden
1 parent 84bb86d commit e57fe4a

5 files changed

Lines changed: 222 additions & 201 deletions

File tree

‎packages/react/src/DataTable/DataTable.tsx‎

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@ import {TableSelectionAnnouncementContext, defaultSelectedCountLabel} from './Ta
2121
import classes from './TableBulkActions.module.css'
2222
import VisuallyHidden from '../_VisuallyHidden'
2323
import {announce} from '@primer/live-region-element'
24+
import {isVisible} from '../internal/utils/isVisible'
2425

2526
export interface DataTableBulkActionsContext {
2627
selectedRows: ReadonlySet<DataTableRowId>
@@ -254,10 +255,15 @@ function DataTableImplementation<Data extends UniqueRow>({
254255
return
255256
}
256257

258+
const table = tableRef.current
259+
if (!table || !isVisible(table)) {
260+
return
261+
}
262+
257263
const announcement = announce(selectionAnnouncement, {
258264
politeness: 'polite',
259265
delayMs: 150,
260-
from: tableRef.current ?? undefined,
266+
from: table,
261267
})
262268
return () => announcement.cancel()
263269
}, [selectionAnnouncement])

‎packages/react/src/DataTable/__tests__/DataTableAnnouncements.test.tsx‎

Lines changed: 0 additions & 177 deletions
This file was deleted.

0 commit comments

Comments
 (0)