Report exceptions thrown from ResultCacheMetaExtension during result cache restore as internal errors (#5853)

Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
Co-authored-by: Markus Staab <markus.staab@redaxo.de>

Author: 3 people

.github/workflows/e2e-tests.yml

@@ -336,6 +336,17 @@ jobs:
               echo "$OUTPUT"
               ../bashunit -a matches "Note: Using configuration file .+phpstan.neon." "$OUTPUT"
               ../bashunit -a contains 'Result cache not used because the metadata do not match: metaExtensions' "$OUTPUT"
+          - script: |
+              cd e2e/result-cache-meta-extension-throw
+              composer install
+              # https://github.com/phpstan/phpstan/issues/14805
+              # An exception thrown from ResultCacheMetaExtension::getHash() during result cache
+              # restore must fail the run with a non-zero exit code - even when a bootstrap file
+              # installs a global exception handler that would otherwise swallow it into exit 0.
+              OUTPUT=$(../bashunit -a exit_code "1" "../../bin/phpstan --error-format=raw")
+              echo "$OUTPUT"
+              ../bashunit -a contains 'boom from getHash' "$OUTPUT"
+              ../bashunit -a not_contains 'Swallowed by global exception handler' "$OUTPUT"
           - script: |
               cd e2e/result-cache-restore-without-reflection
               composer install

composer.json

@@ -144,7 +144,8 @@
 				"patches/Resolver.patch"
 			],
 			"symfony/console": [
-				"patches/OutputFormatter.patch"
+				"patches/OutputFormatter.patch",
+				"patches/Application.patch"
 			]
 		}
 	},

composer.lock

@@ -0,0 +1 @@
+/vendor

e2e/result-cache-meta-extension-throw/.gitignore

@@ -0,0 +1,13 @@
+<?php
+
+declare(strict_types=1);
+
+// Simulates a bootstrap file (e.g. larastan booting Laravel) that installs a
+// global exception handler swallowing uncaught exceptions into a clean exit.
+// Without PHPStan catching the ResultCacheMetaExtension exception itself, the
+// throw from getHash() during result cache restore would escape to this handler
+// and the process would silently exit 0 - skipping analysis with green CI.
+set_exception_handler(static function (\Throwable $e): void {
+	fwrite(STDERR, 'Swallowed by global exception handler: ' . $e->getMessage() . "\n");
+	exit(0);
+});

e2e/result-cache-meta-extension-throw/bootstrap.php

@@ -0,0 +1,5 @@
+{
+	"autoload-dev": {
+		"classmap": ["src/"]
+	}
+}

e2e/result-cache-meta-extension-throw/composer.json

@@ -0,0 +1,12 @@
+parameters:
+	level: 8
+	paths:
+		- src
+	bootstrapFiles:
+		- bootstrap.php
+
+services:
+	-
+		class: ResultCacheE2E\MetaExtensionThrow\ThrowingResultCacheMetaExtension
+		tags:
+			- phpstan.resultCacheMetaExtension

e2e/result-cache-meta-extension-throw/composer.lock

@@ -0,0 +1,10 @@
+<?php
+
+declare(strict_types=1);
+
+namespace ResultCacheE2E\MetaExtensionThrow;
+
+function f(): int
+{
+	return 'definitely not an int';
+}

e2e/result-cache-meta-extension-throw/phpstan.neon

@@ -0,0 +1,21 @@
+<?php
+
+declare(strict_types=1);
+
+namespace ResultCacheE2E\MetaExtensionThrow;
+
+use Error;
+use PHPStan\Analyser\ResultCache\ResultCacheMetaExtension;
+
+final class ThrowingResultCacheMetaExtension implements ResultCacheMetaExtension
+{
+	public function getKey(): string
+	{
+		return 'e2e-throwing-result-cache-meta-extension';
+	}
+
+	public function getHash(): string
+	{
+		throw new Error('boom from getHash');
+	}
+}