Bug
Packing a record that has no CATERPILLAR_FILE_NAME_WRITE context value calls log.Fatal, which kills the process instead of returning an error the pipeline can report via fail_on_error.
Where
internal/pkg/pipeline/task/archive/zip.go and tar.go — GetContextValue(string(task.CtxKeyFileNameWrite)) then log.Fatal("filepath not set in context").
Expected
Return an error from Run so the pipeline fails that task rather than aborting the process.
Found while auditing task READMEs in #96.
Bug
Packing a record that has no
CATERPILLAR_FILE_NAME_WRITEcontext value callslog.Fatal, which kills the process instead of returning an error the pipeline can report viafail_on_error.Where
internal/pkg/pipeline/task/archive/zip.goandtar.go—GetContextValue(string(task.CtxKeyFileNameWrite))thenlog.Fatal("filepath not set in context").Expected
Return an error from
Runso the pipeline fails that task rather than aborting the process.Found while auditing task READMEs in #96.