Skip to content

converter: fail_on_error, task_concurrency, and context are discarded #100

Description

Bug

converter implements UnmarshalYAML onto a mapper that only has name, format, and delimiter. task.Base fields on the YAML (fail_on_error, task_concurrency, context) parse without error and are then dropped — core.Base only gets Name.

Where

internal/pkg/pipeline/task/converter/converter.goUnmarshalYAML copies m.Name and m.Delimiter onto core, never the rest of Base.

Expected

Honor the same Base fields as other tasks, or reject them at load so a pipeline author knows they have no effect.

Found while auditing task READMEs in #96.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions