Error in resurrect achievement items when reduced scoring is enabled

[dlglin]

There is an error in the logic for the ResurrectHW and ResurrectGW achievement items:

webwork2/lib/WeBWorK/AchievementItems/ResurrectHW.pm

Lines 19 to 22 in 3678e21

	sub can_use($self, $set, $records) {
	return $set->assignment_type eq 'default'
	&& (after($set->due_date) || ($set->reduced_scoring_date && after($set->reduced_scoring_date)));
	}

This says that if there is a reduced scoring period, then the student can use the item during that period. This is problematic because it then sets the due date to be 24 hours from the current time.

Consider the following scenario: the reduced scoring date was yesterday, and the close date is in a week. Currently if a student uses a resurrect item on the set, it will set both the reduced scoring date and the close date to tomorrow, so although the student will get an extra 24 hours at full credit, they will lose the rest of the week that they used to have for reduced scoring.

What would be the desired behaviour here? My first thought is to say that students should only be able to use resurrect items on sets that are completely closed, and if they do they will get 24 hours at full credit, with no additional reduced scoring period.

[Alex-Jordan]

In some cases that would create incentive to wait out the reduced scoring period and do no homework until you could use a resurrect item, and then get higher scores. In the scenario you described, I'd want it to set the reduced scoring date to 24 hours from now, and leave the close date alone. Alex Jordan Mathematics Instructor Portland Community College

…

On Thu, Feb 5, 2026, 4:18 PM Danny Glin ***@***.***> wrote: *dlglin* created an issue (openwebwork/webwork2#2907) <https://urldefense.com/v3/__https://github.com/openwebwork/webwork2/issues/2907__;!!Ka_JY85zDv0FFw!loANVrNVjCuOj5jkrPsaCHXJkD4NX_UF07zm1Ua6WTVeZGJyOg8nKngwwj1u0_q5S3Hd-pIf82F949V9yPL2lL6YeWc$> There is an error in the logic for the ResurrectHW and ResurrectGW achievement items: https://github.com/openwebwork/webwork2/blob/3678e212b09434cb5fc9a80cdf213c4054e6fee0/lib/WeBWorK/AchievementItems/ResurrectHW.pm#L19-L22 <https://urldefense.com/v3/__https://github.com/openwebwork/webwork2/blob/3678e212b09434cb5fc9a80cdf213c4054e6fee0/lib/WeBWorK/AchievementItems/ResurrectHW.pm*L19-L22__;Iw!!Ka_JY85zDv0FFw!loANVrNVjCuOj5jkrPsaCHXJkD4NX_UF07zm1Ua6WTVeZGJyOg8nKngwwj1u0_q5S3Hd-pIf82F949V9yPL2NtgKtqo$> This says that if there is a reduced scoring period, then the student can use the item during that period. This is problematic because it then sets the due date to be 24 hours from the current time. Consider the following scenario: the reduced scoring date was yesterday, and the close date is in a week. Currently if a student uses a resurrect item on the set, it will set both the reduced scoring date and the close date to tomorrow, so although the student will get an extra 24 hours at full credit, they will lose the rest of the week that they used to have for reduced scoring. What would be the desired behaviour here? My first thought is to say that students should only be able to use resurrect items on sets that are completely closed, and if they do they will get 24 hours at full credit, with no additional reduced scoring period. — Reply to this email directly, view it on GitHub <https://urldefense.com/v3/__https://github.com/openwebwork/webwork2/issues/2907__;!!Ka_JY85zDv0FFw!loANVrNVjCuOj5jkrPsaCHXJkD4NX_UF07zm1Ua6WTVeZGJyOg8nKngwwj1u0_q5S3Hd-pIf82F949V9yPL2lL6YeWc$>, or unsubscribe <https://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/ABEDOAFZXQJY3CVF2QJRNQL4KPMWLAVCNFSM6AAAAACUFGJUZGVHI2DSMVQWIX3LMV43ASLTON2WKOZTHEYDIMJXGQYDQMQ__;!!Ka_JY85zDv0FFw!loANVrNVjCuOj5jkrPsaCHXJkD4NX_UF07zm1Ua6WTVeZGJyOg8nKngwwj1u0_q5S3Hd-pIf82F949V9yPL2FGDWIpo$> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>