Incorrect message in Amulet of Extension

[dlglin]

The description of the achievement item says that "the test must still be open for this to work", but the code checks if the set closed less than a day ago:

webwork2/lib/WeBWorK/AchievementItems/ExtendDueDateGW.pm

Lines 20 to 25 in 3678e21

	sub can_use ($self, $set, $records) {
	return
	$set->assignment_type =~ /gateway/
	&& $set->set_id !~ /,v\d+$/
	&& between($set->open_date, $set->due_date + ONE_DAY);
	}

I was able to apply the item to a test that closed less than a day ago, and everything appears to work. Can I just remove that statement?

[somiaj]

I would, the extensions can all still be used as long as the student is still the time period in which using it would be beneficial. This was something that wasn't quite correct when I first updated the achievements, so maybe the descriptions were the original logic, but then it was updated to allow students to be able to use them shortly after assignments closed, as long as they were still within the 24 or 48 hour of being able to open the assignment again.

[dlglin]

Similar question about RessurectGW: It says "This item does not allow you to take additional versions of the test."

I think what it means to say is that it doesn't grant you additional versions that you weren't entitled to before. If you use the item you can take additional versions of the test (as long as you hadn't previously used up all of your versions).

Am I interpreting this correctly? Can I clarify this text as well?

[somiaj]

Correct, it only extends the time of the template set, and extends the window they can start new versions, it doesn't actually give any new versions. Though we might have to be careful about that, if there is some setup like they get 2 versions every 12 hours, the extension might be able to actually give them more versions. I don't really use any of those features so don't know the details.

[somiaj]

I wonder if the logic should be updated on the test extensions to only allow them to be used if there is are still any open versions either due to not using up the cap, or the extension giving an additional time period.