Skip to content

SDCICD-1840 Add MCSimulation config keys for Management Cluster simulation#3253

Open
YiqinZhang wants to merge 1 commit into
openshift:mainfrom
YiqinZhang:sdcicd-1840
Open

SDCICD-1840 Add MCSimulation config keys for Management Cluster simulation#3253
YiqinZhang wants to merge 1 commit into
openshift:mainfrom
YiqinZhang:sdcicd-1840

Conversation

@YiqinZhang

Copy link
Copy Markdown
Contributor

Adds configuration keys to support simulating a Management Cluster (MC) environment on ROSA Classic clusters.
This PR is config-only (no consumers yet). Subsequent PRs will add the CRD installation logic, operator restart mechanism, and orchestrator integration that read these keys.

New config keys under mcSimulation.*:

Key Env Var Default Purpose
enable MC_SIMULATION_ENABLE false Feature gate
crds MC_SIMULATION_CRDS "hcp,vpce" CRD aliases to install
operatorNamespace MC_SIMULATION_OPERATOR_NAMESPACE Operator namespace for restart
operatorDeploymentLabel MC_SIMULATION_OPERATOR_DEPLOYMENT_LABEL Pod label selector for restart
skipInfraCheck MC_SIMULATION_SKIP_INFRA_CHECK true Skip infra health checks

Co-authored-by: Cursor cursor@cursor.com

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

There are test jobs defined for this repository which are not configured to run automatically. Comment /test ? to see a list of all defined jobs. Review these jobs and use /test <job> to manually trigger jobs most likely to be impacted by the proposed changes.Comment /pipeline required to trigger all required & necessary jobs.

@coderabbitai

coderabbitai Bot commented Jun 3, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 2cc583a4-18f1-49e4-8849-9463be2ec401

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci

openshift-ci Bot commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: YiqinZhang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 3, 2026
@ritmun

ritmun commented Jun 4, 2026

Copy link
Copy Markdown
Contributor

/override ci/prow/hypershift-pr-check

@openshift-ci

openshift-ci Bot commented Jun 4, 2026

Copy link
Copy Markdown
Contributor

@ritmun: Overrode contexts on behalf of ritmun: ci/prow/hypershift-pr-check

Details

In response to this:

/override ci/prow/hypershift-pr-check

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci

openshift-ci Bot commented Jun 4, 2026

Copy link
Copy Markdown
Contributor

@YiqinZhang: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants