Skip to content

First parameter to add_cfe_tables should be app name #148

@jphickey

Description

@jphickey

Describe the bug
The add_cfe_tables function is declared as follows in arch_build.cmake:
function(add_cfe_tables APP_NAME TBL_SRC_FILES)

The first parameter was intended to be the application name that the table is associated with, but historically any string was accepted since the string just served to make a unique target name.

To Reproduce
Sample_app always passes the string sampleAppTable here.

Expected behavior
Should pass sample_app as first argument.

Code snips

add_cfe_tables(sampleAppTable fsw/tables/sample_app_tbl.c)

System observed on:
Ubuntu

Additional context
No major issue with the current build system, but will may become an issue if/when nasa/cFE#1538 is implemented, and may also become an issue if directory-scope include directories are removed.

Reporter Info
Joseph Hickey, Vantage Systems, Inc.

Metadata

Metadata

Assignees

Type

No type
No fields configured for issues without a type.

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions