Skip to content

Fix nasa#497, checked return value for CFE_SB_DeletePipe() in CF_CFDP…#498

Open
myc-yang wants to merge 1 commit into
nasa:devfrom
myc-yang:497-check-return-value-cfe-sb-deletepipe-disableengine
Open

Fix nasa#497, checked return value for CFE_SB_DeletePipe() in CF_CFDP…#498
myc-yang wants to merge 1 commit into
nasa:devfrom
myc-yang:497-check-return-value-cfe-sb-deletepipe-disableengine

Conversation

@myc-yang
Copy link
Copy Markdown

Checklist (Please check before submitting)

Describe the contribution
In fsw/src/cf_cfdp.c in the function CF_CFDP_DisableEngine(), the return value of CFE_SB_DeletePipe() is ignored. Issue is captured in #497

Testing performed
I updated and ran the unit tests function Test_CF_CFDP_DisableEngine() in unit-test/cf_cfdp_tests.c,

Expected behavior changes

  • API Change: None
  • Behavior Change: If CFE_SB_DeletePipe() returns less than CFE_SUCCESS, then an error event message will be outputted

System(s) tested on

  • Hardware: PC
  • OS: Ubuntu 18.04
  • Versions: [e.g. cFE 6.6, OSAL 4.2, PSP 1.3 for mcp750, any related apps or tools]

Additional context
Add any other context about the contribution here.

Third party code
If included, identify any third party code and provide text file of license

Contributor Info - All information REQUIRED for consideration of pull request
Michael Yang NASA/GSFC

@myc-yang myc-yang requested review from brandt-nasa and dzbaker May 18, 2026 16:07
@chillfig chillfig self-requested a review May 18, 2026 18:36
Copy link
Copy Markdown
Contributor

@chillfig chillfig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Confirmed build and unit test locally.

@myc-yang
Copy link
Copy Markdown
Author

Looks good. Confirmed build and unit test locally.

I ran both and they passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants