Merge pull request #173 from Microsoft/FixParameterInValueForV2

Fix to use display values for parameter location for V2 serialization.

Author: Shwetap05

src/Microsoft.OpenApi/Models/OpenApiParameter.cs

@@ -236,7 +236,7 @@ public void SerializeAsV2WithoutReference(IOpenApiWriter writer)
             else
             {
                 writer.WriteProperty(OpenApiConstants.Name, Name);
-                writer.WriteProperty(OpenApiConstants.In, In.ToString());
+                writer.WriteProperty(OpenApiConstants.In, In.GetDisplayName());
             }
 
             // description

test/Microsoft.OpenApi.Tests/Models/OpenApiDocumentTests.cs

@@ -1762,7 +1762,7 @@ public void SerializeAdvancedDocumentAsV2JsonWorks()
         ""parameters"": [
           {
             ""name"": ""tags"",
-            ""in"": ""Query"",
+            ""in"": ""query"",
             ""description"": ""tags to filter by"",
             ""type"": ""array"",
             ""items"": {
@@ -1771,7 +1771,7 @@ public void SerializeAdvancedDocumentAsV2JsonWorks()
           },
           {
             ""name"": ""limit"",
-            ""in"": ""Query"",
+            ""in"": ""query"",
             ""description"": ""maximum number of results to return"",
             ""type"": ""integer"",
             ""format"": ""int32""
@@ -1954,7 +1954,7 @@ public void SerializeAdvancedDocumentAsV2JsonWorks()
         ""parameters"": [
           {
             ""name"": ""id"",
-            ""in"": ""Path"",
+            ""in"": ""path"",
             ""description"": ""ID of pet to fetch"",
             ""required"": true,
             ""type"": ""integer"",
@@ -2033,7 +2033,7 @@ public void SerializeAdvancedDocumentAsV2JsonWorks()
         ""parameters"": [
           {
             ""name"": ""id"",
-            ""in"": ""Path"",
+            ""in"": ""path"",
             ""description"": ""ID of pet to delete"",
             ""required"": true,
             ""type"": ""integer"",
@@ -2196,7 +2196,7 @@ public void SerializeAdvancedDocumentWithReferenceAsV2JsonWorks()
         ""parameters"": [
           {
             ""name"": ""tags"",
-            ""in"": ""Query"",
+            ""in"": ""query"",
             ""description"": ""tags to filter by"",
             ""type"": ""array"",
             ""items"": {
@@ -2205,7 +2205,7 @@ public void SerializeAdvancedDocumentWithReferenceAsV2JsonWorks()
           },
           {
             ""name"": ""limit"",
-            ""in"": ""Query"",
+            ""in"": ""query"",
             ""description"": ""maximum number of results to return"",
             ""type"": ""integer"",
             ""format"": ""int32""
@@ -2289,7 +2289,7 @@ public void SerializeAdvancedDocumentWithReferenceAsV2JsonWorks()
         ""parameters"": [
           {
             ""name"": ""id"",
-            ""in"": ""Path"",
+            ""in"": ""path"",
             ""description"": ""ID of pet to fetch"",
             ""required"": true,
             ""type"": ""integer"",
@@ -2326,7 +2326,7 @@ public void SerializeAdvancedDocumentWithReferenceAsV2JsonWorks()
         ""parameters"": [
           {
             ""name"": ""id"",
-            ""in"": ""Path"",
+            ""in"": ""path"",
             ""description"": ""ID of pet to delete"",
             ""required"": true,
             ""type"": ""integer"",

test/Microsoft.OpenApi.Tests/Models/OpenApiOperationTests.cs

@@ -421,11 +421,11 @@ public void SerializeAdvancedOperationAsV2JsonWorks()
   ""parameters"": [
     {
       ""name"": ""parameter1"",
-      ""in"": ""Path""
+      ""in"": ""path""
     },
     {
       ""name"": ""parameter2"",
-      ""in"": ""Header""
+      ""in"": ""header""
     },
     {
       ""name"": ""body"",
@@ -489,11 +489,11 @@ public void SerializeAdvancedOperationWithTagAndSecurityAsV2JsonWorks()
   ""parameters"": [
     {
       ""name"": ""parameter1"",
-      ""in"": ""Path""
+      ""in"": ""path""
     },
     {
       ""name"": ""parameter2"",
-      ""in"": ""Header""
+      ""in"": ""header""
     },
     {
       ""name"": ""body"",

test/Microsoft.OpenApi.Tests/Models/OpenApiParameterTests.cs

@@ -190,7 +190,7 @@ public void SerializeReferencedParameterAsV2JsonWithoutReferenceWorks()
             var expected =
                 @"{
   ""name"": ""name1"",
-  ""in"": ""Path""
+  ""in"": ""path""
 }";
 
             // Act