Address review: non-root image, workflow ordering, config + entity cleanup

- Dockerfile: run the JVM as a non-root 'spring' user.
- workflow: smoke now 'needs: build', so it doesn't rebuild and burn its timeout
  when the build has already failed.
- keploy.yml: drop the unused mongoPassword default (this app is Postgres-only).
- Product: remove the setCreatedAt setter; createdAt is @PrePersist-assigned on an
  updatable=false column, so a setter is silently dropped on save and misleads callers.
- seed.sh: fail loudly in create() when the POST fails or returns no id, instead of
  appending an empty id and corrupting later phases.

Signed-off-by: dhananjay6561 <dhananjayaggarwal6561@gmail.com>

Author: dhananjay6561

.github/workflows/spring-boot-product-catalog.yml

@@ -45,6 +45,7 @@ jobs:
 
   smoke:
     name: end-to-end smoke test
+    needs: build
     runs-on: ubuntu-latest
     timeout-minutes: 20
     steps:

spring-boot-product-catalog/Dockerfile

@@ -16,9 +16,11 @@ RUN ./mvnw -B -q -DskipTests clean package
 # ---- Run stage: slim JRE image ----
 FROM eclipse-temurin:21-jre
 WORKDIR /app
-# curl is used by the docker-compose healthcheck.
+# curl is used by the docker-compose healthcheck. Also create a non-root user to run the JVM.
 RUN apt-get update && apt-get install -y --no-install-recommends curl \
-    && rm -rf /var/lib/apt/lists/*
+    && rm -rf /var/lib/apt/lists/* \
+    && addgroup --system spring && adduser --system --ingroup spring spring
 COPY --from=build /app/target/*.jar app.jar
 EXPOSE 8080
+USER spring:spring
 ENTRYPOINT ["java", "-jar", "app.jar"]

spring-boot-product-catalog/keploy.yml

@@ -42,7 +42,6 @@ test:
     skipCoverage: false
     coverageReportPath: ""
     ignoreOrdering: true
-    mongoPassword: default@123
     language: ""
     removeUnusedMocks: false
     preserveFailedMocks: false

spring-boot-product-catalog/seed.sh

@@ -17,9 +17,16 @@ CREATED=()   # ids of products created, in order
 # create '<json>'  -> prints response, appends new id to CREATED
 create() {
   local json="$1" body id
-  body=$(curl -fsS -X POST "$BASE/api/products" -H 'Content-Type: application/json' -d "$json")
+  if ! body=$(curl -fsS -X POST "$BASE/api/products" -H 'Content-Type: application/json' -d "$json"); then
+    echo "  ERROR: create request failed for: $json" >&2
+    exit 1
+  fi
   echo "  created: $body"
   id=$(printf '%s' "$body" | id_of)
+  if [ -z "$id" ]; then
+    echo "  ERROR: no id in create response: $body" >&2
+    exit 1
+  fi
   CREATED+=("$id")
 }
 

spring-boot-product-catalog/src/main/java/io/keploy/productcatalog/model/Product.java

@@ -101,11 +101,9 @@ public void setCategory(String category) {
         this.category = category;
     }
 
+    // Read-only: createdAt is assigned once by @PrePersist and the column is updatable = false,
+    // so there is intentionally no setter — a set would be silently dropped on the next save().
     public Instant getCreatedAt() {
         return createdAt;
     }
-
-    public void setCreatedAt(Instant createdAt) {
-        this.createdAt = createdAt;
-    }
 }