From 77438991b8d1e0faa867c251d88c14dffda1f172 Mon Sep 17 00:00:00 2001 From: Ali Zulfiqar Date: Sat, 5 Sep 2026 22:14:10 +0500 Subject: [PATCH] Recognize existing directories with dots when saving results Signed-off-by: Ali Zulfiqar --- src/evaluate/saving.py | 2 +- tests/test_save.py | 9 +++++++++ 2 files changed, 10 insertions(+), 1 deletion(-) diff --git a/src/evaluate/saving.py b/src/evaluate/saving.py index 4eea1a6a0..ea7e5e3ec 100644 --- a/src/evaluate/saving.py +++ b/src/evaluate/saving.py @@ -53,7 +53,7 @@ def save(path_or_file, **data): def _setup_path(path_or_file, current_time): path_or_file = Path(path_or_file) - is_file = len(path_or_file.suffix) > 0 + is_file = not path_or_file.is_dir() and len(path_or_file.suffix) > 0 if is_file: folder = path_or_file.parent file_name = path_or_file.name diff --git a/tests/test_save.py b/tests/test_save.py index adca53fee..eee55a99a 100644 --- a/tests/test_save.py +++ b/tests/test_save.py @@ -42,3 +42,12 @@ def test_save_to_file(self): for key in SAVE_EXTRA_KEYS: _ = loaded_result_dict.pop(key) self.assertDictEqual(result_dict, loaded_result_dict) + + +def test_save_to_existing_directory_with_suffix(tmp_path): + directory = tmp_path / "experiment.v1" + directory.mkdir() + path = evaluate.save(directory, accuracy=0.75) + assert path.parent == directory + assert path.name.startswith("result-") + assert json.loads(path.read_text())["accuracy"] == 0.75