-
Notifications
You must be signed in to change notification settings - Fork 5
Open
Labels
enhancementNew feature or requestNew feature or requestgithub_actionsPull requests that update GitHub Actions codePull requests that update GitHub Actions code
Description
Act tests currently don't block PRs. We should set up a ruleset to force them to pass before merging PRs.
Act tests are run only when relevant actions/workflows/testdata are edited:
plugin-ci-workflows/.github/workflows/pr-checks-test-ci.yml
Lines 3 to 10 in e739fbe
| on: | |
| pull_request: | |
| branches: | |
| - main | |
| paths: | |
| - "tests/**" | |
| - ".github/workflows/pr-checks-test-ci.yml" | |
| - ".github/workflows/ci.yml" |
We should instead:
- Always run the workflow
- Run act (slow) only when the relevant change, detect the relevant files via https://github.com/marketplace/actions/changed-files
- If no relevant files are updated, short circuit and exit with success, so the workflow succeeds (and the ruleset passed) but act tests (slow) are not run
Metadata
Metadata
Assignees
Labels
enhancementNew feature or requestNew feature or requestgithub_actionsPull requests that update GitHub Actions codePull requests that update GitHub Actions code
Type
Projects
Status
📅 Planned