Enforce CI typechecking for extracted Rig markdown samples (#275)

* Add CI coverage for extracted markdown sample typechecks

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

* Enforce unused checks for extracted markdown sample typecheck

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Author: Copilot

.github/workflows/ci.yml

@@ -28,3 +28,6 @@ jobs:
 
       - name: Test
         run: npm test
+
+      - name: Typecheck extracted markdown rig samples
+        run: npm run sample -- --testNamePattern="skill markdown samples typecheck"

scripts/run-sample.test.ts

@@ -6,7 +6,6 @@
 import { describe, it, expect, beforeEach, vi } from "vitest";
 import { readFileSync, readdirSync } from "fs";
 import { mkdtemp, rm, writeFile } from "fs/promises";
-import { tmpdir } from "os";
 import { resolve } from "path";
 import { Readable, Writable } from "stream";
 import { execFile } from "child_process";
@@ -282,21 +281,32 @@ describe("skill markdown samples", () => {
 
 describe("skill markdown samples typecheck", () => {
   it("typechecks extracted rig programs with npx tsc", async () => {
-    const typecheckDir = await mkdtemp(resolve(tmpdir(), "rig-sample-typecheck-"));
+    const typecheckDir = await mkdtemp(resolve(__dirname, ".tmp-rig-sample-typecheck-"));
     try {
       for (const file of markdownTargets) {
         const markdown = readFileSync(resolve(markdownDir, file), "utf8");
         const code = withTypecheckModel(extractRigCode(markdown));
         const tsFile = resolve(typecheckDir, file.replace(/\.md$/, ".ts"));
         await writeFile(tsFile, `${code}\n`, "utf8");
       }
+      const tsconfigPath = resolve(typecheckDir, "tsconfig.json");
+      await writeFile(
+        tsconfigPath,
+        JSON.stringify(
+          {
+            extends: "../../tsconfig.json",
+            include: ["./*.ts"],
+          },
+          null,
+          2,
+        ),
+      );
 
       await execFileAsync(
         "npx",
-        ["--yes", "--package", "typescript@5.9.3", "--", "tsc", "--noEmit", "--pretty", "false"],
+        ["tsc", "--project", tsconfigPath, "--pretty", "false"],
         {
           cwd: resolve(__dirname, ".."),
-          env: { ...process.env, npm_config_ignore_scripts: "true" },
         },
       );
     } finally {

skills/rig/samples/03-diagnose-test-failure.md

@@ -1,7 +1,7 @@
 # 03 - Diagnose Test Failure
 
 ```rig
-import { agent, p, s } from "rig";
+import { agent, s } from "rig";
 // Agent role: review input.diff for correctness and regression risks. Return only the declared output shape.
 const reviewer = agent({
     model: "mini",
@@ -21,6 +21,5 @@ const reviewer = agent({
     Return only the declared output shape.
   `,
 });
-
 export default reviewer;
 ```

skills/rig/samples/04-generate-readme.md

@@ -1,13 +1,7 @@
 # 04 - Generate Readme
 
 ```rig
-import { agent, p, s } from "rig";
-const ShResult = s.object({
-    ok: s.boolean,
-    stdout: s.string,
-    stderr: s.string,
-    exitCode: s.number
-});
+import { agent, s } from "rig";
 // Agent role: diagnose the failing test result. Do not edit files.
 const diagnose = agent({
     model: "mini",
@@ -22,6 +16,5 @@ const diagnose = agent({
     Do not edit files.
   `,
 });
-
 export default diagnose;
 ```

skills/rig/samples/05-write-readme-intent.md

@@ -1,7 +1,7 @@
 # 05 - Write Readme Intent
 
 ```rig
-import { agent, p, s } from "rig";
+import { agent, s } from "rig";
 // Agent role: generate a concise README for the package. Include install, usage, and API sections.
 const readmeWriter = agent({
     model: "mini",
@@ -14,6 +14,5 @@ const readmeWriter = agent({
     Include install, usage, and API sections.
   `,
 });
-
 export default readmeWriter;
 ```

skills/rig/samples/07-summarize-many-files.md

@@ -1,17 +1,14 @@
 # 07 - Summarize Many Files
 
 ```rig
-import { agent, p, s } from "rig";
-
+import { agent, s } from "rig";
 // Agent role: summarize the repository file list in one sentence.
-
 const summarizeFiles = agent({
   model: "mini",
   instructions: "Summarize the repository file list in one sentence.",
   output: s.object({
     summary: s.string,
   }),
 });
-
 export default summarizeFiles;
 ```

skills/rig/samples/11-release-notes.md

@@ -1,7 +1,7 @@
 # 11 - Release Notes
 
 ```rig
-import { agent, p, s } from "rig";
+import { agent, s } from "rig";
 // Agent role: triage the pull request and recommend reviewers.
 const triage = agent({
     model: "mini",
@@ -13,6 +13,5 @@ const triage = agent({
     }),
     instructions: `Triage the pull request and recommend reviewers.`,
 });
-
 export default triage;
 ```

skills/rig/samples/12-security-scan-review.md

@@ -1,7 +1,7 @@
 # 12 - Security Scan Review
 
 ```rig
-import { agent, p, s } from "rig";
+import { agent, s } from "rig";
 // Agent role: write release notes from commits. Omit empty sections as empty arrays.
 const releaseNotes = agent({
     model: "mini",
@@ -13,6 +13,5 @@ const releaseNotes = agent({
     }),
     instructions: `Write release notes from commits. Omit empty sections as empty arrays.`,
 });
-
 export default releaseNotes;
 ```

skills/rig/samples/13-test-plan.md

@@ -1,7 +1,7 @@
 # 13 - Test Plan
 
 ```rig
-import { agent, p, s } from "rig";
+import { agent, s } from "rig";
 // Agent role: review dependency security posture from the provided outputs.
 const securityReview = agent({
     model: "mini",
@@ -15,6 +15,5 @@ const securityReview = agent({
     }),
     instructions: `Review dependency security posture from the provided outputs.`,
 });
-
 export default securityReview;
 ```

skills/rig/samples/14-changelog-categorizer.md

@@ -1,7 +1,7 @@
 # 14 - Changelog Categorizer
 
 ```rig
-import { agent, p, s } from "rig";
+import { agent, s } from "rig";
 // Agent role: create a focused validation plan for the current changes.
 const planner = agent({
     model: "mini",
@@ -12,6 +12,5 @@ const planner = agent({
     }),
     instructions: `Create a focused validation plan for the current changes.`,
 });
-
 export default planner;
 ```