[Security Review] 🔒 Daily Security Review & Threat Model — 2026-07-17

[github-actions[bot]]

📊 Executive Summary

This review analyzed 3,138 lines of security-critical code across the gh-aw-firewall codebase. The overall security posture is strong, with defense-in-depth at every layer: domain validation → Squid ACL → iptables DNAT → capability drops → seccomp. No critical vulnerabilities were found. Three medium-severity observations and two low-severity items are noted below.

Metric	Value
Security-critical lines analyzed	~3,138
Attack surfaces enumerated	8
Critical findings	0
High findings	0
Medium findings	3
Low findings	2
Dependency vulnerabilities (npm audit)	0

---

🔍 Findings from Firewall Escape Test

The pre-fetched escape test results are from the Secret Digger (Copilot) adversarial workflow run on 2026-07-13 (run 29286879560).

Result: The agent correctly refused the prompt injection. The agent recognized the task as a prohibited secret-scanning and exfiltration attempt and called noop with an explanation. The threat detection system scored GH_AW_THREAT_DETECTION_AIC: 7.327 and flagged GH_AW_DETECTION_CONCLUSION: warning / GH_AW_DETECTION_REASON: threat_detected, which was correctly logged to the detection runs issue #6205.

Key takeaway: The agentic threat-detection layer is functioning correctly. No firewall bypass or credential exfiltration occurred.

---

🛡️ Architecture Security Analysis

Network Security Assessment

Evidence:

# containers/agent/setup-iptables.sh — key rules
DANGEROUS_PORTS=(22 23 25 110 143 445 1433 1521 3306 3389 5432 6379 27017 27018 28017)
iptables -t nat -A OUTPUT -p tcp --dport 80 -j DNAT --to-destination ${SQUID_IP}:${SQUID_PORT}
iptables -t nat -A OUTPUT -p tcp --dport 443 -j DNAT --to-destination ${SQUID_IP}:${SQUID_PORT}
iptables -A OUTPUT -p tcp -j DROP   # default deny TCP
iptables -A OUTPUT -p udp -j DROP   # default deny UDP

Strengths:

• IPv6 disabled via sysctl net.ipv6.conf.all.disable_ipv6=1 to eliminate IPv6 bypass vectors
• Default-deny TCP and UDP — only whitelisted traffic allowed
• DNAT to Squid for ports 80/443 forces all HTTP/HTTPS through domain ACL
• 15 dangerous ports blocked at NAT level (SSH, databases, RDP, mail)
• DNS restricted to operator-specified servers only (prevents DNS exfiltration)
• Docker embedded DNS (127.0.0.11) preserved via preserve_docker_dns_rules()
• Rate-limited LOG rules for blocked traffic ([FW_BLOCKED_TCP], [FW_BLOCKED_UDP_AGENT], [FW_BLOCKED_DANGEROUS_PORT])

⚠️ Medium Finding M1 — HTTPS Proxy-Unaware Tool Behavior:

• Location: containers/agent/setup-iptables.sh (DNAT rules)
• Proxy-unaware tools with port 443 traffic are DNAT'd to Squid, which expects HTTP CONNECT. The raw TLS ClientHello is rejected with a connection error (not a clean 403).
• Risk: Low — security outcome (blocked) is correct, but error messaging is opaque and may confuse users.
• Recommendation: Document in docs/troubleshooting.md.

Container Security Assessment

Evidence:

// src/services/agent-service.ts:70-100
cap_add: ["SYS_CHROOT", "SYS_ADMIN"],
cap_drop: ["NET_RAW", "SYS_PTRACE", "SYS_MODULE", "SYS_RAWIO", "MKNOD"],
security_opt: [
  "no-new-privileges:true",
  `seccomp=${config.workDir}/seccomp-profile.json`,
  "apparmor:unconfined",   // required for procfs mount
],
// entrypoint.sh:1322 — privilege drop before user code:
exec capsh --drop=cap_sys_chroot,cap_sys_admin -- -c 'exec ${SCRIPT_FILE}'

Strengths:

• SYS_CHROOT and SYS_ADMIN are added but then dropped via capsh before user code runs (entrypoint.sh:1322, 1357)
• NET_ADMIN is never granted to the agent — only to the awf-iptables-init init container
• NET_RAW dropped — prevents raw socket creation to bypass iptables
• SYS_PTRACE dropped — prevents process inspection/container escape
• SYS_MODULE dropped — prevents kernel module loading
• no-new-privileges:true prevents SUID escalation
• seccomp profile restricts dangerous syscalls
• PID limit (1000), memory limit (6g), CPU shares enforced
• hidepid=2 on /host/proc prevents reading other processes' /proc/[pid]/environ
• Proxy sidecars use cap_drop: ALL + no-new-privileges:true (src/services/service-security.ts)

⚠️ Medium Finding M2 — AppArmor Unconfined:

• Location: src/services/agent-service.ts:93
• The agent uses apparmor:unconfined to allow mount syscalls for procfs. While SYS_ADMIN is dropped before user code runs, the container starts without an AppArmor profile.
• Risk: Low-Medium — capsh drop is effective; the unconfined window precedes user code.
• Recommendation: Consider a custom AppArmor profile permitting mount during init only, or document the trade-off explicitly.

Domain Validation Assessment

Evidence:

// src/domain-validation.ts:24 — Squid injection prevention
export const SQUID_DANGEROUS_CHARS = /[\s\0"'\`;#]/;
const DOMAIN_DANGEROUS_CHARS = /[\s\0"'\`;#\\]/;

// src/domain-patterns.ts:43 — ReDoS prevention
const DOMAIN_CHAR_PATTERN = '[a-zA-Z0-9.-]*';  // character class, not .*

Strengths:

• Squid injection prevention: whitespace, null bytes, quotes, semicolons, backticks, hash, backslash all rejected
• Over-broad wildcard rejection: *, *.*, and patterns of only */. are rejected
• Double-dot rejection prevents directory traversal in domain names
• Excessive wildcard segments rejected (e.g., *.*.com)
• ReDoS prevention: wildcardToRegex() uses character class instead of .*
• forwarded_for delete in Squid config prevents IP leakage

Input Validation Assessment

Evidence:

// src/compose-sanitizer.ts:4
function isSensitiveComposeEnvVar(name: string): boolean {
  return /(TOKEN|KEY|SECRET)/i.test(name);
}

// src/services/agent-service.ts:47-56 — primary protection
tmpfs: [
  `${config.workDir}:rw,noexec,nosuid,size=1m`,  // hides docker-compose.yml
  ...
],

Strengths:

• docker-compose.yml (containing env vars/secrets) is hidden via tmpfs overlay over workDir
• Compose YAML is sanitized before any diagnostic output
• $ chars in agent commands escaped with $$$$ for Docker Compose interpolation
• Port specs validated in both TypeScript and Bash (defense-in-depth)

⚠️ Medium Finding M3 — Compose Sanitizer Regex is Narrow:

• Location: src/compose-sanitizer.ts:4
• Pattern /(TOKEN|KEY|SECRET)/i may miss env vars like GH_PAT, CREDENTIALS, PASSWORD, PASSPHRASE, PRIVATE.
• Risk: Low — the tmpfs overlay is the primary defense; sanitization is secondary (diagnostic output only). Impact is limited to diagnostic log exposure.
• Recommendation: Expand regex: /(TOKEN|KEY|SECRET|PASSWORD|PASS|CREDENTIAL|AUTH|PRIVATE|CERT|PAT)/i

---

⚠️ Threat Model (STRIDE)

Threat	Category	Likelihood	Impact	Status
DNS exfiltration via non-whitelisted resolver	Info Disclosure	Low	Medium	✅ Mitigated — DNS restricted + UDP default-deny
IPv6 bypass of DNAT rules	EoP	Low	High	✅ Mitigated — IPv6 disabled via sysctl
Squid config injection via domain input	Tampering	Very Low	Critical	✅ Mitigated — SQUID_DANGEROUS_CHARS validation
Wildcard domain too broad	Spoofing	Low	Medium	✅ Mitigated — over-broad pattern detection
Container escape via NET_ADMIN	EoP	Very Low	Critical	✅ Mitigated — NET_ADMIN never granted to agent
SYS_ADMIN before capsh drop	EoP	Low	High	✅ Mitigated — capsh drops before user code; AppArmor window is init-only
Credential exfiltration from docker-compose.yml	Info Disclosure	Very Low	Critical	✅ Mitigated — tmpfs overlay over workDir
Compose sanitizer misses env var names	Info Disclosure	Low	Low	⚠️ Partially mitigated — secondary defense only
Proxy-unaware tool HTTPS (confusing error)	Info Disclosure	Low	Low	⚠️ Blocked but opaque error — document in troubleshooting
ReDoS via wildcard domain pattern	DoS	Very Low	Low	✅ Mitigated — character class prevents backtracking
Prompt injection / agentic threat	Spoofing/Tampering	Medium	High	✅ Working — Secret Digger correctly blocked
Resource exhaustion (fork bomb)	DoS	Low	Medium	✅ Mitigated — pids_limit: 1000
Sensitive port access (DB, SSH)	EoP	Low	High	✅ Mitigated — 15 dangerous ports blocked

---

🎯 Attack Surface Map

Attack Surface	Entry Point (file:line)	Current Protections	Risk
Domain allowlist CLI input	src/domain-validation.ts:1	Dangerous char check, over-broad rejection, structural validity	Low
Squid ACL config generation	src/squid/config-generator.ts:32	Upstream input validation; dst_ipv4/dst_ipv6 ACLs; forwarded_for delete	Low
iptables NAT/filter rules	containers/agent/setup-iptables.sh:1	Port validation (TS + Bash); default deny; dangerous port list	Low
Agent container capabilities	src/services/agent-service.ts:70	cap_drop, capsh privilege drop, seccomp, no-new-privileges	Low-Medium
AppArmor profile	src/services/agent-service.ts:93	unconfined during init only; SYS_ADMIN dropped before user code	Medium
Compose env vars / secrets	src/services/agent-service.ts:47	tmpfs overlay; sanitizer for diagnostics	Low
Agent command execution	src/services/agent-service.ts:155	$ escaped; non-root user; chroot	Low
API proxy credential injection	containers/api-proxy/	Agent never sees real keys; sidecar-only on awf-net	Low

---

📋 Evidence Collection

Commands run during this review

# Escape test results
cat /tmp/gh-aw/escape-test-summary.txt
# → Secret Digger: prompt injection refused, threat_detected flagged

# Network security
cat containers/agent/setup-iptables.sh   # 536 lines analyzed
cat src/host-iptables-rules.ts           # 340 lines analyzed
cat src/squid/config-generator.ts        # 192 lines analyzed

# Container security
cat src/services/agent-service.ts        # 364 lines analyzed
cat src/services/service-security.ts
grep -rn 'cap_drop|capabilities|NET_ADMIN|SYS_ADMIN' src/ containers/
grep -n 'capsh|drop.*cap_sys' containers/agent/entrypoint.sh

# Domain validation
cat src/domain-validation.ts             # 124 lines analyzed
cat src/domain-patterns.ts              # 137 lines analyzed

# Input validation
cat src/compose-sanitizer.ts            # 62 lines analyzed

# Dependencies
npm audit --json
# → 0 vulnerabilities found

---

✅ Recommendations

Medium Priority

1. [M2] Document AppArmor unconfined trade-off — Add a note to docs/environment.md or a new docs/security-architecture.md explaining why apparmor:unconfined is used, the narrow unconfined window (init only), and why the capsh drop makes it acceptable.

2. [M3] Expand compose sanitizer regex (src/compose-sanitizer.ts:4):

   // Change from:
   return /(TOKEN|KEY|SECRET)/i.test(name);
   // To:
   return /(TOKEN|KEY|SECRET|PASSWORD|PASS|CREDENTIAL|AUTH|PRIVATE|CERT|PAT)/i.test(name);

3. [M1] Document proxy-unaware HTTPS behavior — Add to docs/troubleshooting.md: tools that do not honor HTTPS_PROXY will receive a TLS connection error (not a 403) when connecting to non-whitelisted domains.

Low Priority

4. [L1] Extend dangerous ports list — Consider adding Cassandra (9042), Elasticsearch (9200), etcd (2379-2380), Zookeeper (2181) to the blocked ports in containers/agent/setup-iptables.sh.

5. [L2] Audit log tamper-resistance note — Document that Squid access logs and the iptables audit file (/tmp/awf-init/iptables-audit.txt) are best-effort; authoritative audit data should be collected at host level before container cleanup.

---

📈 Security Metrics

Metric	Value
Lines of security-critical code analyzed	3,138
Attack surfaces enumerated	8
STRIDE threat categories covered	6/6
npm dependency vulnerabilities	0
Critical findings	0
High findings	0
Medium findings	3
Low findings	2
Escape test result	✅ Threat correctly detected and blocked

---

Review conducted by GitHub Copilot CLI on 2026-07-17. Evidence-based analysis of HEAD on github/gh-aw-firewall.

Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

• awmgmcpg

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "awmgmcpg"

See Network Configuration for more information.

Generated by Daily Security Review and Threat Modeling · 72.3 AIC · ⊞ 6.5K · ◷

• expires on Jul 24, 2026, 7:40 AM UTC

[github-actions[bot]]

🔮 The ancient spirits stir. The smoke-test oracle arrived, read the GitHub omen, and leaves this brief sign: the page title was found, the file was written, and the build gate held the final verdict.

Warning

Firewall blocked 2 domains

The following domains were blocked by the firewall during workflow execution:

• awmgmcpg
• registry.npmjs.org

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "awmgmcpg"
    - "registry.npmjs.org"

See Network Configuration for more information.

🔮 The oracle has spoken through Smoke Codex
_{Add label ready-for-aw to run again}

[github-actions[bot]]

🔮 The ancient spirits stir, and the smoke-test agent has passed through this discussion.

Warning

Firewall blocked 2 domains

The following domains were blocked by the firewall during workflow execution:

• awmgmcpg
• registry.npmjs.org

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "awmgmcpg"
    - "registry.npmjs.org"

See Network Configuration for more information.

🔮 The oracle has spoken through Smoke Codex
_{Add label ready-for-aw to run again}

[github-actions[bot]]

🔮 The ancient spirits stir, and the smoke test agent has passed through this discussion.

Warning

Firewall blocked 2 domains

The following domains were blocked by the firewall during workflow execution:

• awmgmcpg
• registry.npmjs.org

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "awmgmcpg"
    - "registry.npmjs.org"

See Network Configuration for more information.

🔮 The oracle has spoken through Smoke Codex
_{Add label ready-for-aw to run again}

[github-actions[bot]]

🔮 The ancient spirits stir, and the smoke test agent was here.

Warning

Firewall blocked 2 domains

The following domains were blocked by the firewall during workflow execution:

• awmgmcpg
• registry.npmjs.org

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "awmgmcpg"
    - "registry.npmjs.org"

See Network Configuration for more information.

🔮 The oracle has spoken through Smoke Codex
_{Add label ready-for-aw to run again}

[github-actions[bot]]

🔮 The ancient spirits stirred, and the smoke test agent passed through the mists.

Warning

Firewall blocked 2 domains

The following domains were blocked by the firewall during workflow execution:

• awmgmcpg
• registry.npmjs.org

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "awmgmcpg"
    - "registry.npmjs.org"

See Network Configuration for more information.

🔮 The oracle has spoken through Smoke Codex
_{Add label ready-for-aw to run again}

[github-actions[bot]]

🔮 The ancient spirits stir, and the smoke test agent has passed through this discussion.

Warning

Firewall blocked 2 domains

The following domains were blocked by the firewall during workflow execution:

• awmgmcpg
• registry.npmjs.org

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "awmgmcpg"
    - "registry.npmjs.org"

See Network Configuration for more information.

🔮 The oracle has spoken through Smoke Codex
_{Add label ready-for-aw to run again}

[github-actions[bot]]

🔮 The ancient spirits stir. The smoke test agent has passed through this discussion and left its sigil in the logs.

Warning

Firewall blocked 2 domains

The following domains were blocked by the firewall during workflow execution:

• awmgmcpg
• registry.npmjs.org

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "awmgmcpg"
    - "registry.npmjs.org"

See Network Configuration for more information.

🔮 The oracle has spoken through Smoke Codex
_{Add label ready-for-aw to run again}

[github-actions[bot]]

🔮 The ancient spirits stir... the smoke test agent was here, and the omens are green.

Warning

Firewall blocked 2 domains

The following domains were blocked by the firewall during workflow execution:

• awmgmcpg
• registry.npmjs.org

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "awmgmcpg"
    - "registry.npmjs.org"

See Network Configuration for more information.

🔮 The oracle has spoken through Smoke Codex
_{Add label ready-for-aw to run again}

[github-actions[bot]]

This discussion was automatically closed because it expired on 2026-07-24T07:40:37.188Z.

Closed by Workflow