Fix global value numbering calculation

owen-mc · owen-mc · commit b1f9ccd86096 · 2026-05-28T17:55:09.000+01:00
diff --git a/go/ql/lib/semmle/go/dataflow/GlobalValueNumbering.qll b/go/ql/lib/semmle/go/dataflow/GlobalValueNumbering.qll
@@ -200,7 +200,7 @@ private ControlFlow::Node mostRecentSideEffect(ControlFlow::Node entry, ControlF
 
 cached
 private ControlFlow::Node mostRecentSideEffectUnique(ControlFlow::Node node) {
-  result = unique( | | mostRecentSideEffect(_, node))
+  result = unique( | | mostRecentSideEffect(getControlFlowEntry(node), node))
 }
 
 /** Used to represent the "global value number" of an expression. */

Original file line number	Diff line number	Diff line change
`@@ -200,7 +200,7 @@ private ControlFlow::Node mostRecentSideEffect(ControlFlow::Node entry, ControlF`
`200`	`200`
`201`	`201`	`cached`
`202`	`202`	`private ControlFlow::Node mostRecentSideEffectUnique(ControlFlow::Node node) {`
`203`		`- result = unique( \| \| mostRecentSideEffect(_, node))`
	`203`	`+ result = unique( \| \| mostRecentSideEffect(getControlFlowEntry(node), node))`
`204`	`204`	`}`
`205`	`205`
`206`	`206`	`/** Used to represent the "global value number" of an expression. */`