generated from actions/typescript-action
-
Notifications
You must be signed in to change notification settings - Fork 64
Open
Labels
bugSomething isn't workingSomething isn't working
Description
When a required check fails on a PR and branch-deploy is invoked (e.g. via issue_comment), then the failing check is fixed without a new commit (same head_sha — e.g. editing the PR title so a workflow re-runs and passes), a later branch-deploy invocation can still report that checks do not pass / deployment cannot proceed, even though the PR UI shows all required checks green for the current head.
Steps to reproduce
- Open a PR where a workflow runs on
pull_requesttypes includingeditedand can fail without changinghead_sha(example: validate PR title format). - Confirm the check is failed on the PR head commit.
- Trigger
branch-deploy(e.g. deployment comment) — expect it to correctly refuse while checks fail. - Fix the condition (e.g. edit PR title) so the same workflow runs again and the check turns success for the same
head_sha. - Trigger
branch-deployagain.
Expected behavior
branch-deploy evaluates the latest check results for the PR head and allows the deploy when all required checks pass.
Actual behavior
branch-deploy still reports that checks do not pass (or equivalent), despite the PR showing passing checks.
Environment
github/branch-deployversion: v11 (replace with your exact ref)- Workflow:
on: issue_comment→types: [created] - Required checks include a job not listed in
ignored_checks, which can flip pass/fail onpull_requesteditedwithout a new commit
name: Validate PR title
on:
pull_request:
types: [opened, edited, synchronize, reopened]
jobs:
validate-title:
name: Validate title format
runs-on: ubuntu-latest
steps:
- name: Check PR title
shell: bash
run: |
set -euo pipefail
title="${{ github.event.pull_request.title }}"
echo "PR title: ${title}"
# Required format:
# DEMO-30029 - Restore Demo-CI bacpac for local development
regex='^RAIL-[0-9]+[[:space:]]-[[:space:]].+$'
if [[ ! "${title}" =~ ${regex} ]]; then
echo "Invalid PR title format."
echo "Expected: DEMO-<number> - <description>"
echo "Example: DEMO-30029 - Restore Demo-CI bacpac for local development"
exit 1
fi
echo "PR title format is valid."
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't working
Type
Fields
Give feedbackNo fields configured for issues without a type.