Skip to content

Commit b6d18b5

Browse files
jvnsgitster
authored andcommitted
status: suggest git merge --continue, not git commit
During a merge conflict, we suggest using --continue to continue the merge for rebase, revert, and cherry-pick. Change the `git merge` advice to be consistent. 367ff69 (merge: add '--continue' option as a synonym for 'git commit', 2016-12-14) says that `git merge --continue` is intended to be a synonym for `git commit`, and the `git merge` man page already suggests to use `git merge --continue`. Signed-off-by: Julia Evans <julia@jvns.ca> Acked-by: Phillip Wood <phillip.wood123@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
1 parent a018953 commit b6d18b5

3 files changed

Lines changed: 8 additions & 8 deletions

File tree

‎t/t7060-wtstatus.sh‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ test_expect_success 'M/D conflict does not segfault' '
3737
cat >expect <<EOF &&
3838
On branch side
3939
You have unmerged paths.
40-
(fix conflicts and run "git commit")
40+
(fix conflicts and run "git merge --continue")
4141
(use "git merge --abort" to abort the merge)
4242
4343
Unmerged paths:
@@ -141,7 +141,7 @@ test_expect_success 'status when conflicts with add and rm advice (deleted by th
141141
cat >expected <<\EOF &&
142142
On branch main
143143
You have unmerged paths.
144-
(fix conflicts and run "git commit")
144+
(fix conflicts and run "git merge --continue")
145145
(use "git merge --abort" to abort the merge)
146146
147147
Unmerged paths:
@@ -174,7 +174,7 @@ test_expect_success 'status when conflicts with add and rm advice (both deleted)
174174
cat >expected <<\EOF &&
175175
On branch conflict_second
176176
You have unmerged paths.
177-
(fix conflicts and run "git commit")
177+
(fix conflicts and run "git merge --continue")
178178
(use "git merge --abort" to abort the merge)
179179
180180
Unmerged paths:
@@ -198,7 +198,7 @@ test_expect_success 'status when conflicts with only rm advice (both deleted)' '
198198
cat >expected <<\EOF &&
199199
On branch conflict_second
200200
You have unmerged paths.
201-
(fix conflicts and run "git commit")
201+
(fix conflicts and run "git merge --continue")
202202
(use "git merge --abort" to abort the merge)
203203
204204
Changes to be committed:

‎t/t7512-status-help.sh‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ test_expect_success 'status when conflicts unresolved' '
3131
cat >expected <<\EOF &&
3232
On branch conflicts
3333
You have unmerged paths.
34-
(fix conflicts and run "git commit")
34+
(fix conflicts and run "git merge --continue")
3535
(use "git merge --abort" to abort the merge)
3636
3737
Unmerged paths:
@@ -53,7 +53,7 @@ test_expect_success 'status when conflicts resolved before commit' '
5353
cat >expected <<\EOF &&
5454
On branch conflicts
5555
All conflicts fixed but you are still merging.
56-
(use "git commit" to conclude merge)
56+
(use "git merge --continue" to conclude the merge)
5757
5858
Changes to be committed:
5959
modified: main.txt

‎wt-status.c‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1273,7 +1273,7 @@ static void show_merge_in_progress(struct wt_status *s,
12731273
status_printf_ln(s, color, _("You have unmerged paths."));
12741274
if (s->hints) {
12751275
status_printf_ln(s, color,
1276-
_(" (fix conflicts and run \"git commit\")"));
1276+
_(" (fix conflicts and run \"git merge --continue\")"));
12771277
status_printf_ln(s, color,
12781278
_(" (use \"git merge --abort\" to abort the merge)"));
12791279
}
@@ -1282,7 +1282,7 @@ static void show_merge_in_progress(struct wt_status *s,
12821282
_("All conflicts fixed but you are still merging."));
12831283
if (s->hints)
12841284
status_printf_ln(s, color,
1285-
_(" (use \"git commit\" to conclude merge)"));
1285+
_(" (use \"git merge --continue\" to conclude the merge)"));
12861286
}
12871287
wt_longstatus_print_trailer(s);
12881288
}

0 commit comments

Comments
 (0)