comments

Author: pabloDeputter

sentry_sdk/integrations/stdlib.py

@@ -461,7 +461,8 @@ def close(self: "HTTPResponse") -> None:
 
     HTTPConnection.putrequest = putrequest  # type: ignore[method-assign]
     # patch `HTTPConnection.putrequest()` first. urllib3 < 1.25.9 inherits it, so
-    # wrapping AWS classes first would skip URL and span recording.
+    # wrapping AWS classes first would skip URL and span recording. Once boto3-v1.16.63
+    # support is dropped, we won't have to worry about this issue.
     _patch_aws_connection()
     HTTPConnection.getresponse = getresponse  # type: ignore[method-assign]
     HTTPResponse.read = read  # type: ignore[method-assign]

tests/integrations/boto3/test_trace_propagation.py

@@ -37,7 +37,6 @@ def _start_server():
 
 @pytest.mark.parametrize("span_streaming", [False, True])
 def test_botocore_merges_propagation_before_sigv4_signing(sentry_init, span_streaming):
-    """Merge `sentry-trace` and `baggage` before SigV4 signs them."""
     sentry_init(
         traces_sample_rate=1.0,
         trace_lifecycle="stream" if span_streaming else "static",