Skip to content

Commit a3428aa

Browse files
runningcodeclaude
andcommitted
ref(replay): Trim the v9 AnchoredClock TODOs
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
1 parent 9160901 commit a3428aa

2 files changed

Lines changed: 3 additions & 7 deletions

File tree

‎sentry-android-replay/src/main/java/io/sentry/android/replay/capture/BaseCaptureStrategy.kt‎

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -48,11 +48,8 @@ import kotlin.reflect.KProperty
4848
internal abstract class BaseCaptureStrategy(
4949
private val options: SentryOptions,
5050
private val scopes: IScopes?,
51-
// TODO [MAJOR]: every value this provider stamps is serialized — segment timestamps and
52-
// durations, frame filenames, buffer cutoffs, gesture offsets — and they are all subtracted from
53-
// each other, so a clock step corrupts a recording. Replacing it with an io.sentry.time
54-
// .AnchoredClock re-bases those timestamps and is therefore v9-only. See JAVA-575.
55-
private val dateProvider: ICurrentDateProvider,
51+
// TODO [v9]: We should consider replacing this with AnchoredClock in V9.
52+
dateProvider: ICurrentDateProvider,
5653
private val ticker: MonotonicTicker,
5754
protected val replayExecutor: ScheduledExecutorService,
5855
protected val persistingExecutor: ScheduledExecutorService,

‎sentry-android-replay/src/main/java/io/sentry/android/replay/gestures/ReplayGestureConverter.kt‎

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,8 +13,7 @@ import io.sentry.transport.ICurrentDateProvider
1313
import java.util.concurrent.TimeUnit.MILLISECONDS
1414

1515
internal class ReplayGestureConverter(
16-
// TODO [MAJOR]: the timestamps and timeOffsets stamped from this provider are serialized, so
17-
// moving them onto an io.sentry.time.AnchoredClock is v9-only. See JAVA-575.
16+
// TODO [v9]: Replace this with AnchoredClock in V9
1817
private val dateProvider: ICurrentDateProvider,
1918
private val ticker: MonotonicTicker,
2019
) {

0 commit comments

Comments
 (0)