PR #420 #1280
cameroncookecodeql
on: dynamic
Matrix: analyze
Annotations
9 warnings
|
Analyze (actions)
Cannot retrieve the full diff because there are too many (300) changed files in the pull request.
|
|
Analyze (python)
Cannot retrieve the full diff because there are too many (300) changed files in the pull request.
|
|
Analyze (javascript-typescript)
Cannot retrieve the full diff because there are too many (300) changed files in the pull request.
|
|
Unnarrowed union access on `textItem.text` may fail TypeScript compilation under strict mode:
src/utils/responses/next-steps-renderer.ts#L38
After finding the last text item by index, `textItem` still has type `ToolResponseContent` (a union). Both union members carry `[key: string]: unknown`, so TypeScript resolves `textItem.text` as `string | unknown` → `unknown`, making `unknown + '\n\n' + nextStepsSection` a `+` operator type error. Add a `textItem.type === 'text'` guard after the loop to let TypeScript narrow the variant before accessing `.text`.
|
|
Smoke test compares list_sims output schema against hardcoded v1, but tool now advertises v2:
src/mcp/tools/simulator/list_sims.ts#L179
The `expectedRegistrationSchema(schemaName)` call in `e2e-mcp-discovery.test.ts:93` uses the default `version = '1'`, so it generates a v1 registration schema for comparison — but `manifests/tools/list_sims.yaml` now declares `version: "2"`, meaning the live tool advertises a v2 schema and the assertion will fail.
|
|
[HET-UXX] Smoke test compares list_sims output schema against hardcoded v1, but tool now advertises v2 (additional location):
src/mcp/tools/doctor/doctor.ts#L426
The `expectedRegistrationSchema(schemaName)` call in `e2e-mcp-discovery.test.ts:93` uses the default `version = '1'`, so it generates a v1 registration schema for comparison — but `manifests/tools/list_sims.yaml` now declares `version: "2"`, meaning the live tool advertises a v2 schema and the assertion will fail.
|
|
[HET-UXX] Smoke test compares list_sims output schema against hardcoded v1, but tool now advertises v2 (additional location):
src/mcp/tools/session-management/session_show_defaults.ts#L67
The `expectedRegistrationSchema(schemaName)` call in `e2e-mcp-discovery.test.ts:93` uses the default `version = '1'`, so it generates a v1 registration schema for comparison — but `manifests/tools/list_sims.yaml` now declares `version: "2"`, meaning the live tool advertises a v2 schema and the assertion will fail.
|
|
[HET-UXX] Smoke test compares list_sims output schema against hardcoded v1, but tool now advertises v2 (additional location):
src/mcp/tools/project-discovery/list_schemes.ts#L104
The `expectedRegistrationSchema(schemaName)` call in `e2e-mcp-discovery.test.ts:93` uses the default `version = '1'`, so it generates a v1 registration schema for comparison — but `manifests/tools/list_sims.yaml` now declares `version: "2"`, meaning the live tool advertises a v2 schema and the assertion will fail.
|
|
Accessing `.text` on an unnarrowed `ToolResponseContent` union may be a TypeScript compile error:
src/utils/responses/next-steps-renderer.ts#L42
After confirming `type === 'text'` in the loop, `textItem` is still typed as the full `ToolResponseContent` union; the `image` variant's `[key: string]: unknown` index signature causes `textItem.text` to resolve to `unknown`, making the `+` concatenation a type error under `strict: true`. Narrow the type before use to fix this.
|