Skip to content

Commit 671db5c

Browse files
committed
adopt flutter 3.47 and commit the analyzer block its pub get writes
1 parent 0a1e8a4 commit 671db5c

6 files changed

Lines changed: 81 additions & 21 deletions

File tree

‎.github/workflows/ci.yml‎

Lines changed: 36 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -35,13 +35,18 @@ jobs:
3535

3636
- uses: subosito/flutter-action@v2
3737
with:
38-
# Pinned, not `channel: stable`. Flutter 3.47 (Dart 3.13) landed on
39-
# 2026-08-12 and made `pub publish` warn when git status is not
40-
# clean, and `--dry-run` exits 65 on a warning, so all four package
41-
# jobs went red on a commit that touched three markdown files. A
42-
# toolchain release should not be able to fail a build nobody
43-
# changed. Same reasoning as pinning templ in the server repo.
44-
flutter-version: 3.44.9
38+
# Pinned, not `channel: stable`, and the pin is the point rather than
39+
# the version: 3.47 turned every package job red on a commit that
40+
# touched three markdown files, and a toolchain release should not be
41+
# able to do that. Same reasoning as pinning templ in the server repo.
42+
#
43+
# Bump it deliberately, after running the matrix locally on the new
44+
# version. `analysis_options.yaml` carries an `analyzer: exclude:`
45+
# block because 3.47's `pub get` writes one if it is missing, which
46+
# dirties the tree, which makes `pub publish --dry-run` exit 65 on a
47+
# warning. Deleting that block breaks the package jobs and nothing
48+
# else, so it will look unrelated.
49+
flutter-version: 3.47.0
4550
channel: stable
4651
cache: true
4752

@@ -83,13 +88,18 @@ jobs:
8388

8489
- uses: subosito/flutter-action@v2
8590
with:
86-
# Pinned, not `channel: stable`. Flutter 3.47 (Dart 3.13) landed on
87-
# 2026-08-12 and made `pub publish` warn when git status is not
88-
# clean, and `--dry-run` exits 65 on a warning, so all four package
89-
# jobs went red on a commit that touched three markdown files. A
90-
# toolchain release should not be able to fail a build nobody
91-
# changed. Same reasoning as pinning templ in the server repo.
92-
flutter-version: 3.44.9
91+
# Pinned, not `channel: stable`, and the pin is the point rather than
92+
# the version: 3.47 turned every package job red on a commit that
93+
# touched three markdown files, and a toolchain release should not be
94+
# able to do that. Same reasoning as pinning templ in the server repo.
95+
#
96+
# Bump it deliberately, after running the matrix locally on the new
97+
# version. `analysis_options.yaml` carries an `analyzer: exclude:`
98+
# block because 3.47's `pub get` writes one if it is missing, which
99+
# dirties the tree, which makes `pub publish --dry-run` exit 65 on a
100+
# warning. Deleting that block breaks the package jobs and nothing
101+
# else, so it will look unrelated.
102+
flutter-version: 3.47.0
93103
channel: stable
94104
cache: true
95105

@@ -144,13 +154,18 @@ jobs:
144154

145155
- uses: subosito/flutter-action@v2
146156
with:
147-
# Pinned, not `channel: stable`. Flutter 3.47 (Dart 3.13) landed on
148-
# 2026-08-12 and made `pub publish` warn when git status is not
149-
# clean, and `--dry-run` exits 65 on a warning, so all four package
150-
# jobs went red on a commit that touched three markdown files. A
151-
# toolchain release should not be able to fail a build nobody
152-
# changed. Same reasoning as pinning templ in the server repo.
153-
flutter-version: 3.44.9
157+
# Pinned, not `channel: stable`, and the pin is the point rather than
158+
# the version: 3.47 turned every package job red on a commit that
159+
# touched three markdown files, and a toolchain release should not be
160+
# able to do that. Same reasoning as pinning templ in the server repo.
161+
#
162+
# Bump it deliberately, after running the matrix locally on the new
163+
# version. `analysis_options.yaml` carries an `analyzer: exclude:`
164+
# block because 3.47's `pub get` writes one if it is missing, which
165+
# dirties the tree, which makes `pub publish --dry-run` exit 65 on a
166+
# warning. Deleting that block breaks the package jobs and nothing
167+
# else, so it will look unrelated.
168+
flutter-version: 3.47.0
154169
channel: stable
155170
cache: true
156171

‎analysis_options.yaml‎

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,12 @@
1+
analyzer:
2+
exclude:
3+
- build/**
4+
- android/**
5+
- ios/**
6+
- web/**
7+
- windows/**
8+
- macos/**
9+
- linux/**
110
include: package:flutter_lints/flutter.yaml
211

312
# Additional information about this file can be found at

‎example/analysis_options.yaml‎

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,15 @@
77

88
# The following line activates a set of recommended lints for Flutter apps,
99
# packages, and plugins designed to encourage good coding practices.
10+
analyzer:
11+
exclude:
12+
- build/**
13+
- android/**
14+
- ios/**
15+
- web/**
16+
- windows/**
17+
- macos/**
18+
- linux/**
1019
include: package:flutter_lints/flutter.yaml
1120

1221
linter:

‎packages/code_scout_dio/analysis_options.yaml‎

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,12 @@
1+
analyzer:
2+
exclude:
3+
- build/**
4+
- android/**
5+
- ios/**
6+
- web/**
7+
- windows/**
8+
- macos/**
9+
- linux/**
110
include: package:flutter_lints/flutter.yaml
211

312
# Additional information about this file can be found at

‎packages/code_scout_http/analysis_options.yaml‎

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,12 @@
1+
analyzer:
2+
exclude:
3+
- build/**
4+
- android/**
5+
- ios/**
6+
- web/**
7+
- windows/**
8+
- macos/**
9+
- linux/**
110
include: package:flutter_lints/flutter.yaml
211

312
# Additional information about this file can be found at

‎packages/code_scout_talker/analysis_options.yaml‎

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,12 @@
1+
analyzer:
2+
exclude:
3+
- build/**
4+
- android/**
5+
- ios/**
6+
- web/**
7+
- windows/**
8+
- macos/**
9+
- linux/**
110
include: package:flutter_lints/flutter.yaml
211

312
# Additional information about this file can be found at

0 commit comments

Comments
 (0)