Adjust ApprovalTests to XUnit v4

Author: jnyrup

Build/Build.cs

@@ -118,14 +118,15 @@ class Build : NukeBuild
         {
             Project project = Solution.Specs.Approval_Tests;
 
-            DotNetTest(s => s
+            DotNetBuild(s => s
+                .SetProjectFile(project)
                 .SetConfiguration(Configuration.Release)
                 .SetProcessEnvironmentVariable("DOTNET_CLI_UI_LANGUAGE", "en-US")
-                .EnableNoBuild()
-                .SetResultsDirectory(TestResultsDirectory)
-                .CombineWith(cc => cc
-                    .SetProjectFile(project)
-                    .AddLoggers($"trx;LogFileName={project.Name}.trx")), completeOnFailure: true);
+                .EnableNoRestore()
+                .SetProperty(
+                    "TestingPlatformCommandLineArguments",
+                    $"--report-xunit-trx --report-xunit-trx-filename {project.Name}.trx --results-directory {TestResultsDirectory}")
+                .AddProcessAdditionalArguments("-t:Test"));
 
             ReportTestOutcome(globFilters: $"*{project.Name}.trx");
         });

Tests/Approval.Tests/Approval.Tests.csproj

@@ -9,10 +9,6 @@
     <PackageReference Include="FluentAssertions" Version="8.0.0" />
     <PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.13.0" />
     <PackageReference Include="xunit.v3.core" Version="4.0.0" />
-    <PackageReference Include="xunit.runner.visualstudio" Version="3.1.5">
-      <PrivateAssets>all</PrivateAssets>
-      <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
-    </PackageReference>
     <PackageReference Include="PublicApiGenerator" Version="11.5.4" />
     <PackageReference Include="Verify.DiffPlex" Version="3.3.1" />
     <PackageReference Include="Verify.XunitV3" Version="32.0.0" />