From 7a875556bfe04586236a75b50babfe159c15ec13 Mon Sep 17 00:00:00 2001 From: immanuwell Date: Thu, 28 May 2026 12:28:34 +0400 Subject: [PATCH] kafka: use rd_kafka_conf_destroy in flb_kafka_conf_create error path The error path in flb_kafka_conf_create called flb_free() on a rd_kafka_conf_t pointer returned by rd_kafka_conf_new(). This only frees the top-level struct and skips rd_kafka_anyconf_destroy(), leaking all internally allocated strings (default config values, client.id, group.id, etc.). Replace with rd_kafka_conf_destroy(), which is what every other caller in the codebase already uses to clean up kafka conf objects. Signed-off-by: Immanuel Tikhonov Signed-off-by: immanuwell --- src/flb_kafka.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/flb_kafka.c b/src/flb_kafka.c index 316c9ba9719..6a76c0dca33 100644 --- a/src/flb_kafka.c +++ b/src/flb_kafka.c @@ -95,7 +95,7 @@ rd_kafka_conf_t *flb_kafka_conf_create(struct flb_kafka *kafka, err: if (kafka_cfg) { - flb_free(kafka_cfg); + rd_kafka_conf_destroy(kafka_cfg); } return NULL; }