From eacfa8941e48c7783f901ef09f469bbd07a5d76b Mon Sep 17 00:00:00 2001
From: John McLear <john@mclear.co.uk>
Date: Sun, 10 May 2026 09:04:59 +0100
Subject: [PATCH] a11y: flatten interactive nesting (restore localized
 aria-label)

Flattens nested <a>/<button>/<span> wrappers to a single <a> carrying
the icon classes plus role="button"/tabindex="0". With no element
children (or with data-l10n-id ending in a recognized attribute
suffix), etherpad's html10n auto-populates aria-label from the
localized translation per html10n.ts:665-678.

Restores screen-reader accessibility lost in the Phase 3a aria-label
sweep, where elements with element children plus a non-suffix
data-l10n-id ended up with no accessible name.
---
 templates/editbarButtons.ejs | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/templates/editbarButtons.ejs b/templates/editbarButtons.ejs
index 6fb8504..29253e2 100644
--- a/templates/editbarButtons.ejs
+++ b/templates/editbarButtons.ejs
@@ -1,5 +1,7 @@
-<li id="insertEmbedMedia">
-  <a data-l10n-id="ep_embedmedia.embed" data-l10n-attr="title" title="Embed Media">
-    <button class="buttonicon buttonicon-align-left buttonicon-embed-media" data-align="0" data-l10n-id="ep_embedmedia.embed"></button>
-  </a>
+<li id="insertEmbedMedia" data-type="button" data-key="embedMedia">
+  <a class="buttonicon buttonicon-align-left buttonicon-embed-media"
+     role="button" tabindex="0"
+     data-align="0"
+     data-l10n-id="ep_embedmedia.embed"
+     title="Embed Media"></a>
 </li>