Skip to content

getFile does not handle destination correctly #39

Description

@Vogel612

When calling getFile with a destination that is an absolute path (or more generally, with a path including /) the file is incorrectly stored locally.

The cause of the issue is the replacement of / with \\ in getCleanedSmbClientArgs for the destination argument.

I think this can be somewhat avoided by using the workingDir option, but strictly speaking the destination argument should be exempt from that sort of path modification.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions