-
Notifications
You must be signed in to change notification settings - Fork 101
Open
Labels
enhancementNew feature or requestNew feature or requestgood first issueGood for newcomersGood for newcomers
Description
Default versions for vLLM, SGLang, and llama-server are currently duplicated across multiple files (Dockerfile, Makefile .github/workflows/release.yml, scripts, README). This makes bumping a version error-prone as they easily drift out of sync (e.g. vLLM was 0.12.0 in CI but 0.17.0 in the Dockerfile).
Introduce a single source-of-truth file (e.g. .versions or .env) that defines the defaults, and have each consumer read from it:
- Makefile: VLLM_VERSION ?= $(shell ...)
- Dockerfile: remove ARG defaults; always pass via --build-arg
- CI workflow: read from the file in a setup step, remove hardcoded input defaults
- Shell scripts: source the file or read the relevant value
This ensures a version bump is a one-line change in one file.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
enhancementNew feature or requestNew feature or requestgood first issueGood for newcomersGood for newcomers