Repository navigation
Commit 9d6bd19
committed
localenv: follow include-group when scanning for the user's databricks-connect pin
Review follow-up. PEP 735 {include-group = "..."} is an indirection, so the
user's pin may live in a group the dev group merely references:
[dependency-groups]
dev = [{include-group = "spark"}]
spark = ["databricks-connect==16.1.0"]
The previous scan only walked dev's own string entries, so it found no pin and
emitted no W_DBCONNECT_PIN_OVERRIDDEN — while MergeManaged still injects the
env's pin into dev, leaving the file with two pins for the same package and no
advisory that one replaced the other. groupRequirements now resolves the
reference chain, normalizing group names per PEP 503 (which PEP 735 also
specifies) and skipping already-visited groups so an include-group cycle
terminates. Decoding dependency-groups as a map is what makes the other groups
reachable; the walk is deterministic despite the map because warning order is
fixed downstream.
Also scopes the environment-marker check to the post-extras remainder rather
than the raw requirement, so it tests only where a marker can appear. Behavior
is unchanged for every input either form decides — a ";" in a url requirement is
still skipped, which costs nothing since a url has no comparable version range.
This closes a false negative that predates the warnings work rather than a
regression from it: the parent commit reported nothing for the same input too.
Co-authored-by: Isaac1 parent 7f28303 commit 9d6bd19
2 files changed
Lines changed: 115 additions & 21 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
22 | 22 | | |
23 | 23 | | |
24 | 24 | | |
25 | | - | |
26 | | - | |
27 | | - | |
28 | | - | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
29 | 28 | | |
30 | | - | |
31 | | - | |
32 | | - | |
33 | | - | |
34 | | - | |
| 29 | + | |
35 | 30 | | |
36 | 31 | | |
37 | 32 | | |
| |||
43 | 38 | | |
44 | 39 | | |
45 | 40 | | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
46 | 50 | | |
47 | 51 | | |
48 | 52 | | |
| |||
60 | 64 | | |
61 | 65 | | |
62 | 66 | | |
63 | | - | |
64 | | - | |
65 | | - | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
66 | 70 | | |
67 | 71 | | |
68 | | - | |
69 | | - | |
70 | | - | |
71 | | - | |
72 | | - | |
73 | | - | |
74 | | - | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
75 | 109 | | |
76 | 110 | | |
| 111 | + | |
77 | 112 | | |
78 | 113 | | |
79 | 114 | | |
| |||
114 | 149 | | |
115 | 150 | | |
116 | 151 | | |
117 | | - | |
| 152 | + | |
118 | 153 | | |
119 | 154 | | |
120 | 155 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
114 | 114 | | |
115 | 115 | | |
116 | 116 | | |
| 117 | + | |
| 118 | + | |
| 119 | + | |
| 120 | + | |
| 121 | + | |
| 122 | + | |
| 123 | + | |
| 124 | + | |
| 125 | + | |
| 126 | + | |
| 127 | + | |
| 128 | + | |
| 129 | + | |
| 130 | + | |
| 131 | + | |
| 132 | + | |
| 133 | + | |
| 134 | + | |
| 135 | + | |
| 136 | + | |
| 137 | + | |
| 138 | + | |
| 139 | + | |
| 140 | + | |
| 141 | + | |
| 142 | + | |
| 143 | + | |
| 144 | + | |
| 145 | + | |
| 146 | + | |
| 147 | + | |
| 148 | + | |
| 149 | + | |
| 150 | + | |
| 151 | + | |
| 152 | + | |
| 153 | + | |
| 154 | + | |
| 155 | + | |
| 156 | + | |
| 157 | + | |
| 158 | + | |
| 159 | + | |
| 160 | + | |
| 161 | + | |
| 162 | + | |
| 163 | + | |
| 164 | + | |
| 165 | + | |
| 166 | + | |
| 167 | + | |
| 168 | + | |
| 169 | + | |
| 170 | + | |
| 171 | + | |
| 172 | + | |
117 | 173 | | |
118 | 174 | | |
119 | 175 | | |
| |||
132 | 188 | | |
133 | 189 | | |
134 | 190 | | |
135 | | - | |
| 191 | + | |
| 192 | + | |
136 | 193 | | |
137 | 194 | | |
| 195 | + | |
| 196 | + | |
138 | 197 | | |
139 | 198 | | |
140 | 199 | | |
| |||
0 commit comments