`ghostel--anchor-window` shouldn't move the cursor in line-mode

[papercatlol]

In particular this is very inconvenient because any command that grows the minibuffer (e.g. M-x) will move the cursor to (point-max) in line-mode.

[dakra]

Should be fixed on main.
And since I don't use line-mode myself very much, please don't hesitate to report any bugs or feature requests.

[papercatlol]

Thank you for all the work you guys do! I'm really enjoying ghostel so far.

There is another case here that your commit doesn't fix which happens when the resized window is too small to fit both (point) and (point-max). It is easy to reproduce by having the cursor on the first line in the ghostel window, shell prompt on the last line and then opening a minibuffer a couple lines high. You will notice the cursor jump to the middle of the window.

The following patch fixes this issue for me, although ideally the cursor shouldn't move at all in line-mode (as opposed to moving it and restoring the position after).

1 file changed, 2 insertions(+), 2 deletions(-)
lisp/ghostel.el | 4 ++--

modified   lisp/ghostel.el
@@ -4596,12 +4596,12 @@ user's point, since its input region is user-owned."
                                  ghostel--pixel-anchor-supported-p
                                  (ghostel--pixel-anchor window target))))
               (progn
-                (set-window-start window (car anchor))
+                (set-window-start window (car anchor) 'noforce)
                 (ghostel--set-window-vscroll window (cdr anchor) t t))
             (let ((lines (window-screen-lines)))
               (goto-char target)
               (forward-line (- (floor lines)))
-              (set-window-start window (point))
+              (set-window-start window (point) 'noforce)
               (ghostel--set-window-vscroll window 0 t t)))
           (set-window-point window (if (eq ghostel--input-mode 'line)
                                        orig

[dakra]

@papercatlol that minimal 'noforce patch lgtm. Do you want to send a PR?

[emil-e]

@dakra @papercatlol Just be careful to not break the pixel vscroll stuff... the noforce parameter has suprising interactions when you also set vscroll. So make sure that the bottom line is still pixel-pinned to the bottom and that resizing doesn't jitter when the terminal is at the bottom.

[papercatlol]

@papercatlol that minimal 'noforce patch lgtm. Do you want to send a PR?

Will do after I look at the pixel scroll