Skip to content

Commit 55113f2

Browse files
committed
Build the e2e-spawned ck-synapse with test-support so SYNAPSE_TEST_* overrides apply
The catalog test hooks are gated on the module's own test-support feature, but the binary the end-to-end tests spawn was built without it, so every override was compiled out. The default-catalog test only passed on macOS because real Metal detection happened to agree with the override; on Linux it reported backend_unavailable. A self dev-dependency turns the feature on for test builds only. Verified live: forcing the runnable set to cuda now makes the same test fail on macOS, and restoring metal makes it pass.
1 parent 9461b2b commit 55113f2

2 files changed

Lines changed: 6 additions & 0 deletions

File tree

‎Cargo.lock‎

Lines changed: 1 addition & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎crates/synapse-module/Cargo.toml‎

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -58,6 +58,11 @@ subc-os = { workspace = true }
5858
subc-transport = { workspace = true }
5959
tokenizers = { workspace = true }
6060
synapse-engine-owned = { path = "../synapse-engine-owned", features = ["test-support"] }
61+
# Turns on this crate's own test-support feature in test builds, so the
62+
# ck-synapse binary the end-to-end tests spawn honours the SYNAPSE_TEST_*
63+
# overrides (catalog, runnable backends, download barriers). Release builds
64+
# never see it.
65+
synapse-module = { path = ".", features = ["test-support"] }
6166
tracing-subscriber = { version = "0.3", features = ["env-filter", "fmt"] }
6267

6368
[target.'cfg(target_os = "macos")'.dependencies]

0 commit comments

Comments
 (0)