Description
I've got a Modal component which renders the modal box + its children if it's own open prop is set to true. This is run through VelocityTransitionGroup, which means if the open prop changes, it'll add remove/children respectively.
This causes an infinite render bug due, which I believe is due to lines 34 - 36 in GatewayRegistry.js.
Background information
The purpose of using react-gateway was to avoid an issue with nested forms, where the modal rendered its own form, after being triggered by an existing form's element event.
Question
Why is it necessary to completely delete all the children?
If my Modal is set to open={true}, it'll continuously try to re-render the children, because sending a <Modal open={true} /> into Gateway instructs the modal to add its own children, thus triggering componentWillReceiveProps onGateway, and effectively deleting it and adding it continuously.
Description
I've got a
Modalcomponent which renders the modal box + its children if it's ownopenprop is set totrue. This is run throughVelocityTransitionGroup, which means if theopenprop changes, it'll add remove/children respectively.This causes an infinite render bug due, which I believe is due to lines 34 - 36 in GatewayRegistry.js.
Background information
The purpose of using
react-gatewaywas to avoid an issue with nested forms, where the modal rendered its own form, after being triggered by an existingform's element event.Question
Why is it necessary to completely delete all the children?
If my
Modalis set toopen={true}, it'll continuously try to re-render the children, because sending a<Modal open={true} />intoGatewayinstructs the modal to add its own children, thus triggeringcomponentWillReceivePropsonGateway, and effectively deleting it and adding it continuously.