Skip to content

Commit fa8d6fc

Browse files
ci: Build checkout images after restoring cache
Cached or pre-pulled images currently replace the cluster and DNS images built from the pull request under the same tags. Build checkout-owned images last so integration tests consistently exercise the submitted source on both cache hits and misses. Assisted-by: AI Signed-off-by: HarshwardhanPatil07 <harshpat@redhat.com>
1 parent d42e7c3 commit fa8d6fc

1 file changed

Lines changed: 16 additions & 14 deletions

File tree

‎.github/actions/setup-bink/action.yml‎

Lines changed: 16 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -80,20 +80,6 @@ runs:
8080
shell: bash
8181
run: make build-bink
8282

83-
- name: Build cluster and DNS images
84-
shell: bash
85-
run: |
86-
make build-cluster-image
87-
make build-dns-image
88-
89-
- name: Verify prerequisites
90-
shell: bash
91-
run: |
92-
test -f ./bink
93-
podman images --format "table {{.Repository}}:{{.Tag}}\t{{.Size}}"
94-
df -h /
95-
free -h
96-
9783
- name: Get image digests
9884
id: digests
9985
shell: bash
@@ -139,3 +125,19 @@ runs:
139125
with:
140126
path: /tmp/podman-image-cache
141127
key: podman-images-v2-${{ inputs.cache-key-prefix }}-${{ steps.digests.outputs.hash }}
128+
129+
# Build checkout-owned images after loading the cache so published images
130+
# cannot replace changes made by the pull request under the same tags.
131+
- name: Build cluster and DNS images
132+
shell: bash
133+
run: |
134+
make build-cluster-image
135+
make build-dns-image
136+
137+
- name: Verify prerequisites
138+
shell: bash
139+
run: |
140+
test -f ./bink
141+
podman images --format "table {{.Repository}}:{{.Tag}}\t{{.Size}}"
142+
df -h /
143+
free -h

0 commit comments

Comments
 (0)