Skip to content

Commit 3df9cf7

Browse files
fryanpanclaude
andcommitted
ADFA-4128 (1/11): address CodeRabbit review
- F1713-9 stop the pipeline diagrams implying the deploy decision reads the changed set Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FstXxJ5cwWPcvmhZ9vJgJ7
1 parent c79b5ce commit 3df9cf7

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

‎quickbuild/docs/pipeline.md‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -112,7 +112,7 @@ sequenceDiagram
112112
D-->>S: relinked resource apk
113113
end
114114
Note over S: GenerationTracker.next() -> gen N<br/>(allocated ONLY after compile+dex succeed)
115-
Note over S: DeployPolicy.decide(changedClasses)<br/>-> Recreate (hot swap)
115+
Note over S: DeployPolicy.decide()<br/>keys on the app's declared components,<br/>not on what this build recompiled<br/>-> Recreate (hot swap)
116116
S->>Ch: deploy(gen N, dex, arsc?, assets?, meta)
117117
Note over Ch: subscribe to reports BEFORE the<br/>oneway call, open payloads as read-only fds
118118
Ch->>App: onPayload(gen N, dexFd, arscFd, assetsFd, meta)
@@ -488,7 +488,7 @@ flowchart TB
488488
489489
subgraph decide["Deploy decision (inside the executed build)"]
490490
gen["GenerationTracker.next()<br/><i>persist-before-return; gaps ok, reuse never</i>"]
491-
pol["DeployPolicy.decide(changedClasses)"]
491+
pol["DeployPolicy.decide()<br/><i>keys on declared components; the recompiled<br/>set only picks the pre-v2 fallback</i>"]
492492
rec["Recreate (hot swap)"]:::out
493493
res["Restart (service/provider/Application<br/>in supertype closure)"]:::out
494494
reb["RebuildProxyApp (pre-v2 baseline)"]:::out

0 commit comments

Comments
 (0)