We currently define sketch-specific value traits (DensityValue from #62, CountMinValue) that expose only the operations needed by each sketch. There is growing overlap between them.
For example, DensityValue is implemented for f32/f64, and we sometimes convert to f64 for operations.
Proposal
Evaluate replacing these traits with appropriate traits from num-traits (e.g., Float) to:
- Reduce duplication
- Reuse well-known numeric abstractions
- Avoid unnecessary conversions
This is exploratory.
We currently define sketch-specific value traits (
DensityValuefrom #62,CountMinValue) that expose only the operations needed by each sketch. There is growing overlap between them.For example,
DensityValueis implemented forf32/f64, and we sometimes convert tof64for operations.Proposal
Evaluate replacing these traits with appropriate traits from num-traits (e.g.,
Float) to:This is exploratory.