Use allowlisted Rust toolchain action revision (#1661)

timsaucer · web-flow · commit 5cc32306a843 · 2026-07-28T15:15:29.000-04:00
* Use allowlisted Rust toolchain action revision

AI Disclosure: This code was written in part by an AI agent.:

* Set rust toolchain so developer and CI get a consistent experience

* minor clippy fixes
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
@@ -48,7 +48,7 @@ jobs:
       - uses: actions/checkout@v6
 
       - name: Setup Rust
-        uses: dtolnay/rust-toolchain@4be7066ada62dd38de10e7b70166bc74ed198c30
+        uses: dtolnay/rust-toolchain@4cda84d5c5c54efe2404f9d843567869ab1699d4
         with:
           toolchain: "nightly"
           components: rustfmt
@@ -152,7 +152,7 @@ jobs:
           path: .
 
       - name: Setup Rust
-        uses: dtolnay/rust-toolchain@29eef336d9b2848a0b548edc03f92a220660cdb8
+        uses: dtolnay/rust-toolchain@4cda84d5c5c54efe2404f9d843567869ab1699d4
 
       - name: Cache Cargo
         uses: Swatinem/rust-cache@v2
@@ -231,7 +231,7 @@ jobs:
           path: .
 
       - name: Setup Rust
-        uses: dtolnay/rust-toolchain@29eef336d9b2848a0b548edc03f92a220660cdb8
+        uses: dtolnay/rust-toolchain@4cda84d5c5c54efe2404f9d843567869ab1699d4
 
       - name: Cache Cargo
         uses: Swatinem/rust-cache@v2
@@ -286,7 +286,8 @@ jobs:
     steps:
       - uses: actions/checkout@v6
 
-      - uses: dtolnay/rust-toolchain@29eef336d9b2848a0b548edc03f92a220660cdb8
+      - name: Setup Rust
+        uses: dtolnay/rust-toolchain@4cda84d5c5c54efe2404f9d843567869ab1699d4
 
       - run: rm LICENSE.txt
       - name: Download LICENSE.txt
@@ -368,7 +369,8 @@ jobs:
     steps:
       - uses: actions/checkout@v6
 
-      - uses: dtolnay/rust-toolchain@29eef336d9b2848a0b548edc03f92a220660cdb8
+      - name: Setup Rust
+        uses: dtolnay/rust-toolchain@4cda84d5c5c54efe2404f9d843567869ab1699d4
 
       - run: rm LICENSE.txt
       - name: Download LICENSE.txt
diff --git a/crates/core/src/expr.rs b/crates/core/src/expr.rs
@@ -433,7 +433,7 @@ impl PyExpr {
             Expr::Literal(scalar_value, _) => scalar_to_pyarrow(scalar_value, py),
             _ => Err(py_type_err(format!(
                 "Non Expr::Literal encountered in types: {:?}",
-                &self.expr
+                self.expr
             ))),
         }
     }
@@ -612,7 +612,7 @@ impl PyExpr {
             _ => {
                 return Err(py_type_err(format!(
                     "Catch all triggered in get_operator_name: {:?}",
-                    &self.expr
+                    self.expr
                 )));
             }
         })
diff --git a/crates/core/src/expr/aggregate.rs b/crates/core/src/expr/aggregate.rs
@@ -65,8 +65,8 @@ impl Display for PyAggregate {
             \nAggregates(s): {:?}
             \nInput: {:?}
             \nProjected Schema: {:?}",
-            &self.aggregate.group_expr,
-            &self.aggregate.aggr_expr,
+            self.aggregate.group_expr,
+            self.aggregate.aggr_expr,
             self.aggregate.input,
             self.aggregate.schema
         )
diff --git a/crates/core/src/expr/alias.rs b/crates/core/src/expr/alias.rs
@@ -53,7 +53,7 @@ impl Display for PyAlias {
             "Alias
             \nExpr: `{:?}`
             \nAlias Name: `{}`",
-            &self.alias.expr, &self.alias.name
+            self.alias.expr, self.alias.name
         )
     }
 }
diff --git a/crates/core/src/expr/between.rs b/crates/core/src/expr/between.rs
@@ -55,7 +55,7 @@ impl Display for PyBetween {
             Negated: {:?}
             Low: {:?}
             High: {:?}",
-            &self.between.expr, &self.between.negated, &self.between.low, &self.between.high
+            self.between.expr, self.between.negated, self.between.low, self.between.high
         )
     }
 }
diff --git a/crates/core/src/expr/bool_expr.rs b/crates/core/src/expr/bool_expr.rs
@@ -46,7 +46,7 @@ impl Display for PyNot {
             f,
             "Not
             Expr: {}",
-            &self.expr
+            self.expr
         )
     }
 }
@@ -82,7 +82,7 @@ impl Display for PyIsNotNull {
             f,
             "IsNotNull
             Expr: {}",
-            &self.expr
+            self.expr
         )
     }
 }
@@ -118,7 +118,7 @@ impl Display for PyIsNull {
             f,
             "IsNull
             Expr: {}",
-            &self.expr
+            self.expr
         )
     }
 }
@@ -154,7 +154,7 @@ impl Display for PyIsTrue {
             f,
             "IsTrue
             Expr: {}",
-            &self.expr
+            self.expr
         )
     }
 }
@@ -190,7 +190,7 @@ impl Display for PyIsFalse {
             f,
             "IsFalse
             Expr: {}",
-            &self.expr
+            self.expr
         )
     }
 }
@@ -226,7 +226,7 @@ impl Display for PyIsUnknown {
             f,
             "IsUnknown
             Expr: {}",
-            &self.expr
+            self.expr
         )
     }
 }
@@ -262,7 +262,7 @@ impl Display for PyIsNotTrue {
             f,
             "IsNotTrue
             Expr: {}",
-            &self.expr
+            self.expr
         )
     }
 }
@@ -298,7 +298,7 @@ impl Display for PyIsNotFalse {
             f,
             "IsNotFalse
             Expr: {}",
-            &self.expr
+            self.expr
         )
     }
 }
@@ -334,7 +334,7 @@ impl Display for PyIsNotUnknown {
             f,
             "IsNotUnknown
             Expr: {}",
-            &self.expr
+            self.expr
         )
     }
 }
@@ -370,7 +370,7 @@ impl Display for PyNegative {
             f,
             "Negative
             Expr: {}",
-            &self.expr
+            self.expr
         )
     }
 }
diff --git a/crates/core/src/expr/create_memory_table.rs b/crates/core/src/expr/create_memory_table.rs
@@ -57,10 +57,7 @@ impl Display for PyCreateMemoryTable {
             Input: {:?}
             if_not_exists: {:?}
             or_replace: {:?}",
-            &self.create.name,
-            &self.create.input,
-            &self.create.if_not_exists,
-            &self.create.or_replace,
+            self.create.name, self.create.input, self.create.if_not_exists, self.create.or_replace,
         )
     }
 }
diff --git a/crates/core/src/expr/create_view.rs b/crates/core/src/expr/create_view.rs
@@ -58,7 +58,7 @@ impl Display for PyCreateView {
             input: {:?}
             or_replace: {:?}
             definition: {:?}",
-            &self.create.name, &self.create.input, &self.create.or_replace, &self.create.definition,
+            self.create.name, self.create.input, self.create.or_replace, self.create.definition,
         )
     }
 }
diff --git a/crates/core/src/expr/drop_table.rs b/crates/core/src/expr/drop_table.rs
@@ -56,7 +56,7 @@ impl Display for PyDropTable {
             name: {:?}
             if_exists: {:?}
             schema: {:?}",
-            &self.drop.name, &self.drop.if_exists, &self.drop.schema,
+            self.drop.name, self.drop.if_exists, self.drop.schema,
         )
     }
 }
diff --git a/crates/core/src/expr/empty_relation.rs b/crates/core/src/expr/empty_relation.rs
@@ -56,7 +56,7 @@ impl Display for PyEmptyRelation {
             "Empty Relation
             Produce One Row: {:?}
             Schema: {:?}",
-            &self.empty.produce_one_row, &self.empty.schema
+            self.empty.produce_one_row, self.empty.schema
         )
     }
 }
diff --git a/crates/core/src/expr/explain.rs b/crates/core/src/expr/explain.rs
@@ -61,11 +61,11 @@ impl Display for PyExplain {
             stringified_plans: {:?}
             schema: {:?}
             logical_optimization_succeeded: {:?}",
-            &self.explain.verbose,
-            &self.explain.plan,
-            &self.explain.stringified_plans,
-            &self.explain.schema,
-            &self.explain.logical_optimization_succeeded
+            self.explain.verbose,
+            self.explain.plan,
+            self.explain.stringified_plans,
+            self.explain.schema,
+            self.explain.logical_optimization_succeeded
         )
     }
 }
diff --git a/crates/core/src/expr/filter.rs b/crates/core/src/expr/filter.rs
@@ -57,7 +57,7 @@ impl Display for PyFilter {
             "Filter
             Predicate: {:?}
             Input: {:?}",
-            &self.filter.predicate, &self.filter.input
+            self.filter.predicate, self.filter.input
         )
     }
 }
diff --git a/crates/core/src/expr/higher_order_function.rs b/crates/core/src/expr/higher_order_function.rs
@@ -52,7 +52,7 @@ impl Display for PyHigherOrderFunction {
             f,
             "HigherOrderFunction(name={}, args={:?})",
             self.higher_order.name(),
-            &self.higher_order.args,
+            self.higher_order.args,
         )
     }
 }
diff --git a/crates/core/src/expr/join.rs b/crates/core/src/expr/join.rs
@@ -132,14 +132,14 @@ impl Display for PyJoin {
             JoinConstraint: {:?}
             Schema: {:?}
             NullEquality: {:?}",
-            &self.join.left,
-            &self.join.right,
-            &self.join.on,
-            &self.join.filter,
-            &self.join.join_type,
-            &self.join.join_constraint,
-            &self.join.schema,
-            &self.join.null_equality,
+            self.join.left,
+            self.join.right,
+            self.join.on,
+            self.join.filter,
+            self.join.join_type,
+            self.join.join_constraint,
+            self.join.schema,
+            self.join.null_equality,
         )
     }
 }
diff --git a/crates/core/src/expr/lambda.rs b/crates/core/src/expr/lambda.rs
@@ -51,7 +51,7 @@ impl Display for PyLambda {
         write!(
             f,
             "Lambda(params={:?}, body={:?})",
-            &self.lambda.params, &self.lambda.body,
+            self.lambda.params, self.lambda.body,
         )
     }
 }
diff --git a/crates/core/src/expr/lambda_variable.rs b/crates/core/src/expr/lambda_variable.rs
@@ -46,7 +46,7 @@ impl From<PyLambdaVariable> for LambdaVariable {
 
 impl Display for PyLambdaVariable {
     fn fmt(&self, f: &mut Formatter) -> fmt::Result {
-        write!(f, "LambdaVariable({})", &self.variable.name)
+        write!(f, "LambdaVariable({})", self.variable.name)
     }
 }
 
diff --git a/crates/core/src/expr/like.rs b/crates/core/src/expr/like.rs
@@ -55,10 +55,10 @@ impl Display for PyLike {
             Expr: {:?}
             Pattern: {:?}
             Escape_Char: {:?}",
-            &self.negated(),
-            &self.expr(),
-            &self.pattern(),
-            &self.escape_char()
+            self.negated(),
+            self.expr(),
+            self.pattern(),
+            self.escape_char()
         )
     }
 }
@@ -119,10 +119,10 @@ impl Display for PyILike {
             Expr: {:?}
             Pattern: {:?}
             Escape_Char: {:?}",
-            &self.negated(),
-            &self.expr(),
-            &self.pattern(),
-            &self.escape_char()
+            self.negated(),
+            self.expr(),
+            self.pattern(),
+            self.escape_char()
         )
     }
 }
@@ -183,10 +183,10 @@ impl Display for PySimilarTo {
             Expr: {:?}
             Pattern: {:?}
             Escape_Char: {:?}",
-            &self.negated(),
-            &self.expr(),
-            &self.pattern(),
-            &self.escape_char()
+            self.negated(),
+            self.expr(),
+            self.pattern(),
+            self.escape_char()
         )
     }
 }
diff --git a/crates/core/src/expr/limit.rs b/crates/core/src/expr/limit.rs
@@ -57,7 +57,7 @@ impl Display for PyLimit {
             Skip: {:?}
             Fetch: {:?}
             Input: {:?}",
-            &self.limit.skip, &self.limit.fetch, &self.limit.input
+            self.limit.skip, self.limit.fetch, self.limit.input
         )
     }
 }
diff --git a/crates/core/src/expr/projection.rs b/crates/core/src/expr/projection.rs
@@ -65,7 +65,7 @@ impl Display for PyProjection {
             \nExpr(s): {:?}
             \nInput: {:?}
             \nProjected Schema: {:?}",
-            &self.projection.expr, &self.projection.input, &self.projection.schema,
+            self.projection.expr, self.projection.input, self.projection.schema,
         )
     }
 }
diff --git a/crates/core/src/expr/repartition.rs b/crates/core/src/expr/repartition.rs
@@ -82,7 +82,7 @@ impl Display for PyRepartition {
             "Repartition
             input: {:?}
             partitioning_scheme: {:?}",
-            &self.repartition.input, &self.repartition.partitioning_scheme,
+            self.repartition.input, self.repartition.partitioning_scheme,
         )
     }
 }
diff --git a/crates/core/src/expr/sort.rs b/crates/core/src/expr/sort.rs
@@ -61,7 +61,7 @@ impl Display for PySort {
             \nExpr(s): {:?}
             \nInput: {:?}
             \nSchema: {:?}",
-            &self.sort.expr,
+            self.sort.expr,
             self.sort.input,
             self.sort.input.schema()
         )
diff --git a/crates/core/src/expr/sort_expr.rs b/crates/core/src/expr/sort_expr.rs
@@ -54,7 +54,7 @@ impl Display for PySortExpr {
             Expr: {:?}
             Asc: {:?}
             NullsFirst: {:?}",
-            &self.sort.expr, &self.sort.asc, &self.sort.nulls_first
+            self.sort.expr, self.sort.asc, self.sort.nulls_first
         )
     }
 }
diff --git a/crates/core/src/expr/table_scan.rs b/crates/core/src/expr/table_scan.rs
diff --git a/crates/core/src/expr/union.rs b/crates/core/src/expr/union.rs
diff --git a/crates/core/src/expr/unnest.rs b/crates/core/src/expr/unnest.rs
diff --git a/crates/core/src/expr/unnest_expr.rs b/crates/core/src/expr/unnest_expr.rs
diff --git a/crates/core/src/expr/window.rs b/crates/core/src/expr/window.rs
diff --git a/rust-toolchain.toml b/rust-toolchain.toml

Original file line number	Diff line number	Diff line change
`@@ -433,7 +433,7 @@ impl PyExpr {`
`433`	`433`	`Expr::Literal(scalar_value, _) => scalar_to_pyarrow(scalar_value, py),`
`434`	`434`	`_ => Err(py_type_err(format!(`
`435`	`435`	`"Non Expr::Literal encountered in types: {:?}",`
`436`		`- &self.expr`
	`436`	`+ self.expr`
`437`	`437`	`))),`
`438`	`438`	`}`
`439`	`439`	`}`
`@@ -612,7 +612,7 @@ impl PyExpr {`
`612`	`612`	`_ => {`
`613`	`613`	`return Err(py_type_err(format!(`
`614`	`614`	`"Catch all triggered in get_operator_name: {:?}",`
`615`		`- &self.expr`
	`615`	`+ self.expr`
`616`	`616`	`)));`
`617`	`617`	`}`
`618`	`618`	`})`
Original file line number	Diff line number	Diff line change
`@@ -53,7 +53,7 @@ impl Display for PyAlias {`
`53`	`53`	`"Alias`
`54`	`54`	\nExpr: `{:?}`
`55`	`55`	\nAlias Name: `{}`",
`56`		`- &self.alias.expr, &self.alias.name`
	`56`	`+ self.alias.expr, self.alias.name`
`57`	`57`	`)`
`58`	`58`	`}`
`59`	`59`	`}`
Original file line number	Diff line number	Diff line change
`@@ -55,7 +55,7 @@ impl Display for PyBetween {`
`55`	`55`	`Negated: {:?}`
`56`	`56`	`Low: {:?}`
`57`	`57`	`High: {:?}",`
`58`		`- &self.between.expr, &self.between.negated, &self.between.low, &self.between.high`
	`58`	`+ self.between.expr, self.between.negated, self.between.low, self.between.high`
`59`	`59`	`)`
`60`	`60`	`}`
`61`	`61`	`}`
Original file line number	Diff line number	Diff line change
`@@ -46,7 +46,7 @@ impl Display for PyNot {`
`46`	`46`	`f,`
`47`	`47`	`"Not`
`48`	`48`	`Expr: {}",`
`49`		`- &self.expr`
	`49`	`+ self.expr`
`50`	`50`	`)`
`51`	`51`	`}`
`52`	`52`	`}`
`@@ -82,7 +82,7 @@ impl Display for PyIsNotNull {`
`82`	`82`	`f,`
`83`	`83`	`"IsNotNull`
`84`	`84`	`Expr: {}",`
`85`		`- &self.expr`
	`85`	`+ self.expr`
`86`	`86`	`)`
`87`	`87`	`}`
`88`	`88`	`}`
`@@ -118,7 +118,7 @@ impl Display for PyIsNull {`
`118`	`118`	`f,`
`119`	`119`	`"IsNull`
`120`	`120`	`Expr: {}",`
`121`		`- &self.expr`
	`121`	`+ self.expr`
`122`	`122`	`)`
`123`	`123`	`}`
`124`	`124`	`}`
`@@ -154,7 +154,7 @@ impl Display for PyIsTrue {`
`154`	`154`	`f,`
`155`	`155`	`"IsTrue`
`156`	`156`	`Expr: {}",`
`157`		`- &self.expr`
	`157`	`+ self.expr`
`158`	`158`	`)`
`159`	`159`	`}`
`160`	`160`	`}`
`@@ -190,7 +190,7 @@ impl Display for PyIsFalse {`
`190`	`190`	`f,`
`191`	`191`	`"IsFalse`
`192`	`192`	`Expr: {}",`
`193`		`- &self.expr`
	`193`	`+ self.expr`
`194`	`194`	`)`
`195`	`195`	`}`
`196`	`196`	`}`
`@@ -226,7 +226,7 @@ impl Display for PyIsUnknown {`
`226`	`226`	`f,`
`227`	`227`	`"IsUnknown`
`228`	`228`	`Expr: {}",`
`229`		`- &self.expr`
	`229`	`+ self.expr`
`230`	`230`	`)`
`231`	`231`	`}`
`232`	`232`	`}`
`@@ -262,7 +262,7 @@ impl Display for PyIsNotTrue {`
`262`	`262`	`f,`
`263`	`263`	`"IsNotTrue`
`264`	`264`	`Expr: {}",`
`265`		`- &self.expr`
	`265`	`+ self.expr`
`266`	`266`	`)`
`267`	`267`	`}`
`268`	`268`	`}`
`@@ -298,7 +298,7 @@ impl Display for PyIsNotFalse {`
`298`	`298`	`f,`
`299`	`299`	`"IsNotFalse`
`300`	`300`	`Expr: {}",`
`301`		`- &self.expr`
	`301`	`+ self.expr`
`302`	`302`	`)`
`303`	`303`	`}`
`304`	`304`	`}`
`@@ -334,7 +334,7 @@ impl Display for PyIsNotUnknown {`
`334`	`334`	`f,`
`335`	`335`	`"IsNotUnknown`
`336`	`336`	`Expr: {}",`
`337`		`- &self.expr`
	`337`	`+ self.expr`
`338`	`338`	`)`
`339`	`339`	`}`
`340`	`340`	`}`
`@@ -370,7 +370,7 @@ impl Display for PyNegative {`
`370`	`370`	`f,`
`371`	`371`	`"Negative`
`372`	`372`	`Expr: {}",`
`373`		`- &self.expr`
	`373`	`+ self.expr`
`374`	`374`	`)`
`375`	`375`	`}`
`376`	`376`	`}`
Original file line number	Diff line number	Diff line change
`@@ -57,10 +57,7 @@ impl Display for PyCreateMemoryTable {`
`57`	`57`	`Input: {:?}`
`58`	`58`	`if_not_exists: {:?}`
`59`	`59`	`or_replace: {:?}",`
`60`		`- &self.create.name,`
`61`		`- &self.create.input,`
`62`		`- &self.create.if_not_exists,`
`63`		`- &self.create.or_replace,`
	`60`	`+ self.create.name, self.create.input, self.create.if_not_exists, self.create.or_replace,`
`64`	`61`	`)`
`65`	`62`	`}`
`66`	`63`	`}`
Original file line number	Diff line number	Diff line change
`@@ -58,7 +58,7 @@ impl Display for PyCreateView {`
`58`	`58`	`input: {:?}`
`59`	`59`	`or_replace: {:?}`
`60`	`60`	`definition: {:?}",`
`61`		`- &self.create.name, &self.create.input, &self.create.or_replace, &self.create.definition,`
	`61`	`+ self.create.name, self.create.input, self.create.or_replace, self.create.definition,`
`62`	`62`	`)`
`63`	`63`	`}`
`64`	`64`	`}`
Original file line number	Diff line number	Diff line change
`@@ -56,7 +56,7 @@ impl Display for PyDropTable {`
`56`	`56`	`name: {:?}`
`57`	`57`	`if_exists: {:?}`
`58`	`58`	`schema: {:?}",`
`59`		`- &self.drop.name, &self.drop.if_exists, &self.drop.schema,`
	`59`	`+ self.drop.name, self.drop.if_exists, self.drop.schema,`
`60`	`60`	`)`
`61`	`61`	`}`
`62`	`62`	`}`
Original file line number	Diff line number	Diff line change
`@@ -56,7 +56,7 @@ impl Display for PyEmptyRelation {`
`56`	`56`	`"Empty Relation`
`57`	`57`	`Produce One Row: {:?}`
`58`	`58`	`Schema: {:?}",`
`59`		`- &self.empty.produce_one_row, &self.empty.schema`
	`59`	`+ self.empty.produce_one_row, self.empty.schema`
`60`	`60`	`)`
`61`	`61`	`}`
`62`	`62`	`}`