feat(video): Add post call transcription#609
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #609 +/- ##
=========================================
Coverage 98.93% 98.93%
- Complexity 3607 3610 +3
=========================================
Files 542 542
Lines 7953 7987 +34
Branches 443 443
=========================================
+ Hits 7868 7902 +34
Misses 64 64
Partials 21 21 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
Adds post-call transcription support to the Video Archive model and expands test coverage with JSON fixtures and new unit tests around transcription request/response fields.
Changes:
- Added transcription-related fields and nested types to
Archiveplus builder support for request options. - Added new unit tests and JSON fixtures covering serialization/deserialization of transcription fields.
- Updated
CHANGELOG.mdto note the new Video transcription capability.
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/main/java/com/vonage/client/video/Archive.java | Adds transcription request/response fields, nested models, and builder methods. |
| src/test/java/com/vonage/client/video/ArchiveTest.java | Adds tests and helper methods to validate transcription JSON serialization/deserialization. |
| src/test/resources/com/vonage/client/video/archive-*.json | Adds JSON fixtures for new transcription scenarios. |
| CHANGELOG.md | Documents the new post-call transcription options. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| All notable changes to this project will be documented in this file. | ||
| This project adheres to [Semantic Versioning](http://semver.org/). | ||
|
|
||
| # Unreleasd |
There was a problem hiding this comment.
Typo in the changelog section header: 'Unreleasd' should be 'Unreleased' (and ideally match existing section header formatting).
| # Unreleasd | |
| # [Unreleased] |
| * | ||
| * @return This builder. | ||
| */ | ||
| public Builder hasTranscription(boolean hasTranscription) { |
There was a problem hiding this comment.
Using a primitive boolean here makes it impossible to represent 'unset' once the method is called (and may cause hasTranscription: false to be serialized when callers didn’t intend to send the field). Consider changing the parameter to Boolean, or adding an overload like hasTranscription(Boolean hasTranscription) (or an enableTranscription() convenience method) so API consumers can explicitly control omission vs. false.
| public Builder hasTranscription(boolean hasTranscription) { | |
| public Builder hasTranscription(boolean hasTranscription) { | |
| return hasTranscription(Boolean.valueOf(hasTranscription)); | |
| } | |
| /** | |
| * (OPTIONAL) Whether the archive will have transcription. | |
| * Allows {@code null} to represent an unset value, so the field can be omitted. | |
| * | |
| * @param hasTranscription {@code Boolean.TRUE} to enable transcription, | |
| * {@code Boolean.FALSE} to disable it, | |
| * or {@code null} to leave it unset. | |
| * | |
| * @return This builder. | |
| */ | |
| public Builder hasTranscription(Boolean hasTranscription) { |
Added post call transcription options for Video
Contribution Checklist