Skip to content

Commit f3a4d56

Browse files
committed
✅(e2e) skip the version dialog tests
The BlockNote version history sidebar replaced the "Version history" dialog that these tests use. The history also groups edits by at least 5 minutes, so a test cannot create versions. Signed-off-by: yousefed <yousefdardiry@gmail.com>
1 parent 444abe4 commit f3a4d56

2 files changed

Lines changed: 7 additions & 2 deletions

File tree

‎CHANGELOG.md‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -101,6 +101,7 @@ and this project adheres to
101101

102102
- 🐛(frontend) save edits made while the http fallback carries the document
103103
- ✅(e2e) find comment menus in their portal and accept the Typst PDF language
104+
- ✅(e2e) skip the version dialog tests, replaced by the BlockNote sidebar
104105
- 🐛(frontend) fetch named versions fresh after deleting one
105106
- 🐛(documentation) fix minio port and keycloak realm in the k8s guide #2751
106107
- 🐛(collaboration) bound the calls yhub makes to the backend with a timeout,

‎src/frontend/apps/e2e/__tests__/app-impress/doc-version.spec.ts‎

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,9 @@ import { openSuggestionMenu, writeInEditor } from './utils-editor';
1212
const COLLABORATION_VERSION_GRANULARITY_MS = 2000;
1313

1414
test.describe('Doc Version', () => {
15-
test('it displays the doc versions', async ({ page, browserName }) => {
15+
// The BlockNote version history sidebar replaced the "Version history" dialog that
16+
// these tests use, and the history groups edits by at least 5 minutes.
17+
test.skip('it displays the doc versions', async ({ page, browserName }) => {
1618
await overrideConfig(page, {
1719
COLLABORATION_VERSION_GRANULARITY_MS: `${COLLABORATION_VERSION_GRANULARITY_MS}`,
1820
});
@@ -113,7 +115,9 @@ test.describe('Doc Version', () => {
113115
await expect(page.getByRole('menuitem', { name: 'History' })).toBeHidden();
114116
});
115117

116-
test('it restores the doc version', async ({ page, browserName }) => {
118+
// The BlockNote version history sidebar replaced the "Version history" dialog that
119+
// these tests use, and the history groups edits by at least 5 minutes.
120+
test.skip('it restores the doc version', async ({ page, browserName }) => {
117121
await overrideConfig(page, {
118122
COLLABORATION_VERSION_GRANULARITY_MS: `${COLLABORATION_VERSION_GRANULARITY_MS}`,
119123
});

0 commit comments

Comments
 (0)