fix(solid-form): generate an SSR-safe default formId (#2263)

* fix(solid-form): generate an SSR-safe default formId

`createForm` never passed a `formId` to `FormApi`, so it fell back to
`uuid()`, which is seeded from `Math.random()` and therefore differs
between the server render and the client render. Binding it
(`<form id={form.formId}>`) produced a hydration mismatch under
SolidStart.

Use Solid's `createUniqueId()` for the default instead, which is what
the other adapters already do:

- react-form/src/useFormId.ts   — React.useId, falling back to useUUID on React 17
- preact-form/src/useFormId.ts  — useId from preact/hooks
- vue-form/src/useFormId.ts     — Vue's useId, added in #2259

An explicitly provided `formId` is still preserved.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

* docs(solid-form): correct changeset wording for the formId fallback

An explicitly provided `formId` was already forwarded to `FormApi`; only
the fallback was missing. Say that, and capitalize the framework names.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>

Author: harshit-d3v

.changeset/great-pugs-shave.md

@@ -0,0 +1,5 @@
+---
+'@tanstack/solid-form': patch
+---
+
+Generate the default `formId` with Solid's `createUniqueId` so it is SSR-safe. Previously, when no `formId` was configured, `createForm` did not provide a fallback, so `FormApi` generated a random UUID that differed between the server render and the client render. Binding that generated id (`<form id={form.formId}>`) produced a hydration mismatch under SolidStart. An explicitly provided `formId` was already forwarded and is unchanged. This mirrors the existing behaviour of the React, Preact, and Vue adapters.

packages/solid-form/src/createForm.tsx

@@ -1,5 +1,5 @@
 import { FormApi, functionalUpdate } from '@tanstack/form-core'
-import { createComputed, onMount } from 'solid-js'
+import { createComputed, createUniqueId, onMount } from 'solid-js'
 import { useSelector } from '@tanstack/solid-store'
 import { Field, createField } from './createField'
 import { FormGroup } from './createFormGroup'
@@ -240,6 +240,14 @@ export function createForm<
   >,
 ) {
   const options = opts?.()
+  /**
+   * `FormApi` falls back to `uuid()` when no `formId` is given, which differs
+   * between the server render and the client render. `createUniqueId` is
+   * Solid's SSR-safe counterpart, so binding the id (`<form id={form.formId}>`)
+   * no longer produces a hydration mismatch. Mirrors `useFormId` in the React,
+   * Preact, and Vue adapters.
+   */
+  const fallbackFormId = createUniqueId()
   const api = new FormApi<
     TParentData,
     TFormOnMount,
@@ -253,7 +261,7 @@ export function createForm<
     TFormOnDynamicAsync,
     TFormOnServer,
     TSubmitMeta
-  >(options)
+  >({ ...options, formId: options?.formId ?? fallbackFormId })
   const extendedApi: typeof api &
     SolidFormApi<
       TParentData,

packages/solid-form/tests/createFormId.test.tsx

@@ -0,0 +1,36 @@
+import { describe, expect, it } from 'vitest'
+import { render } from '@solidjs/testing-library'
+import { createForm } from '../src/index'
+
+function Comp() {
+  const form = createForm(() => ({ defaultValues: { firstName: '' } }))
+  return <form id={form.formId} data-testid="form" />
+}
+
+describe('createForm formId', () => {
+  it('uses the provided formId when one is given', () => {
+    function WithId() {
+      const form = createForm(() => ({
+        defaultValues: { firstName: '' },
+        formId: 'my-form',
+      }))
+      return <form id={form.formId} data-testid="form" />
+    }
+
+    const { getByTestId } = render(() => <WithId />)
+
+    expect(getByTestId('form').getAttribute('id')).toBe('my-form')
+  })
+
+  it('derives the default formId from Solid so it survives hydration', () => {
+    // `form-core` falls back to `uuid()`, which is seeded from `Math.random()`
+    // and so differs between the server render and the client render. Solid's
+    // `createUniqueId()` is the adapter's SSR-safe counterpart: on the client
+    // it yields `cl-<n>`, and under hydration it derives the id from the
+    // hydration context so both renders agree. Asserting the id comes from
+    // that sequence is what pins the default to the hydration-safe source.
+    const { getByTestId } = render(() => <Comp />)
+
+    expect(getByTestId('form').getAttribute('id')).toMatch(/^cl-\d+$/)
+  })
+})