Skip to content

Question on hard-coding bags_checked to 0 during rebooking #202

Description

@stevehuang52

In https://github.com/ServiceNow/eva/blob/2.1.0/src/eva/assistant/tools/airline_tools.py#L554, the bags_checked is hardcoded as 0 when rebooking flights. However, in general it seems okay to assume that the number of checked bags is directly carried over from the old flight to the new flight. Although there's an add_baggage_allowance to let the agent do it after rebooking, there's no mentioning of this tool in the agent's policy, making the agents almost never call add_baggage_allowance after rebooking, and this affects 17 of the 50 scenarios where the groundtruth expect the carried-over value of 1 but got the hardcoded value of 0.

Could you please explain if the hard-coded 0 is intended or a bug?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions