feat(ios): pass a Swift Package authorization provider to xcodebuild

Private Swift Package registries need xcodebuild to be told which
credential source to use, and the flag was not reachable through the
CLI at all. NS_PACKAGE_AUTHORIZATION_PROVIDER supplies it.

The provider describes how the machine stores its credentials rather
than what is being built, so it reads from the environment instead of
spending a command-line option on it.

Author: edusperoni

lib/services/ios/xcodebuild-args-service.ts

@@ -180,6 +180,19 @@ export class XcodebuildArgsService implements IXcodebuildArgsService {
 			skipMacroValidation,
 		];
 
+		// Selects how xcodebuild authenticates against private Swift Package
+		// registries ("netrc" or "keychain"). It describes the machine's
+		// credential setup rather than the build, so it is read from the
+		// environment instead of a command-line option.
+		const packageAuthorizationProvider =
+			process.env.NS_PACKAGE_AUTHORIZATION_PROVIDER;
+		if (packageAuthorizationProvider) {
+			extraArgs.push(
+				"-packageAuthorizationProvider",
+				packageAuthorizationProvider,
+			);
+		}
+
 		const BUILD_SETTINGS_FILE_PATH = path.join(
 			projectData.appResourcesDirectoryPath,
 			platformData.normalizedPlatformName,

test/services/ios/xcodebuild-args-service.ts

@@ -83,6 +83,16 @@ function getBuildLoggingArgs(logLevel: string): string[] {
 
 describe("xcodebuildArgsService", () => {
 	describe("getXcodeProjectArgs", () => {
+		const originalAuthProvider = process.env.NS_PACKAGE_AUTHORIZATION_PROVIDER;
+
+		afterEach(() => {
+			if (originalAuthProvider === undefined) {
+				delete process.env.NS_PACKAGE_AUTHORIZATION_PROVIDER;
+			} else {
+				process.env.NS_PACKAGE_AUTHORIZATION_PROVIDER = originalAuthProvider;
+			}
+		});
+
 		it("should allow SWIFT_ENABLE_EXPLICIT_MODULES to be overridden from build.xcconfig", () => {
 			const injector = createTestInjector({
 				logLevel: "INFO",
@@ -119,6 +129,66 @@ describe("xcodebuildArgsService", () => {
 
 			assert.include(actualArgs, "DEVELOPMENT_TEAM=TEAM123");
 		});
+
+		it("passes the package authorization provider from the environment", () => {
+			process.env.NS_PACKAGE_AUTHORIZATION_PROVIDER = "netrc";
+			const injector = createTestInjector({
+				logLevel: "INFO",
+				hasProjectWorkspace: false,
+			});
+			const xcodebuildArgsService: IXcodebuildArgsService = injector.resolve(
+				"xcodebuildArgsService",
+			);
+
+			const actualArgs = xcodebuildArgsService.getXcodeProjectArgs(
+				<any>{ projectRoot, normalizedPlatformName },
+				<any>{ projectName, appResourcesDirectoryPath },
+			);
+
+			const index = actualArgs.indexOf("-packageAuthorizationProvider");
+			assert.notStrictEqual(index, -1);
+			assert.strictEqual(actualArgs[index + 1], "netrc");
+		});
+
+		it("omits the package authorization provider when unset", () => {
+			delete process.env.NS_PACKAGE_AUTHORIZATION_PROVIDER;
+			const injector = createTestInjector({
+				logLevel: "INFO",
+				hasProjectWorkspace: false,
+			});
+			const xcodebuildArgsService: IXcodebuildArgsService = injector.resolve(
+				"xcodebuildArgsService",
+			);
+
+			const actualArgs = xcodebuildArgsService.getXcodeProjectArgs(
+				<any>{ projectRoot, normalizedPlatformName },
+				<any>{ projectName, appResourcesDirectoryPath },
+			);
+
+			assert.notInclude(actualArgs, "-packageAuthorizationProvider");
+		});
+
+		it("keeps the project path as the second argument", () => {
+			process.env.NS_PACKAGE_AUTHORIZATION_PROVIDER = "keychain";
+			const injector = createTestInjector({
+				logLevel: "INFO",
+				hasProjectWorkspace: false,
+			});
+			const xcodebuildArgsService: IXcodebuildArgsService = injector.resolve(
+				"xcodebuildArgsService",
+			);
+
+			const actualArgs = xcodebuildArgsService.getXcodeProjectArgs(
+				<any>{ projectRoot, normalizedPlatformName },
+				<any>{ projectName, appResourcesDirectoryPath },
+			);
+
+			assert.strictEqual(actualArgs[0], "-project");
+			assert.strictEqual(
+				actualArgs[1],
+				path.join(projectRoot, `${projectName}.xcodeproj`),
+			);
+		});
 	});
 
 	describe("getBuildForSimulatorArgs", () => {