Address review comments

Author: usiems

src/PythonQt.cpp

@@ -882,9 +882,8 @@ bool PythonQt::addSignalHandler(QObject* obj, const char* signal, PyObject* modu
   PythonQtObjectPtr callable = lookupCallable(module, objectname);
   if (callable) {
     return _p->addSignalHandler(obj, signal, callable);
-  } else {
-    // callable not found
   }
+  // callable not found
   return false;
 }
 
@@ -898,9 +897,8 @@ bool PythonQt::removeSignalHandler(QObject* obj, const char* signal, PyObject* m
   PythonQtObjectPtr callable = lookupCallable(module, objectname);
   if (callable) {
     return _p->removeSignalHandler(obj, signal, callable);
-  } else {
-    // callable not found
   }
+  // callable not found
   return false;
 }
 
@@ -1977,21 +1975,20 @@ PythonQtClassInfo* PythonQtPrivate::lookupClassInfoAndCreateIfNotPresent(const c
 
 bool PythonQtPrivate::addSignalHandler(QObject* sender, const char* signal, PyObject* callable)
 {
-  // Note: It is assumed that the GIL is held when this is called
-  bool ok = false;
+  PYTHONQT_GIL_SCOPE
   int sigId = PythonQtSignalReceiver::getSignalIndex(sender, signal);
   if (sigId >= 0) {
     // create PythonQtMethodInfo from signal
     auto* receiver = new PythonQtSignalReceiver(sender, sigId, callable);
     _signalReceivers.insert(SignalKey(sender, sigId), receiver);
-    ok = true;
+    return true;
   }
-  return ok;
+  return false;
 }
 
 bool PythonQtPrivate::removeSignalHandler(QObject* sender, const char* signal, PyObject* callable)
 {
-  // Note: It is assumed that the GIL is held when this is called
+  PYTHONQT_GIL_SCOPE
   int foundCount = 0;
   int sigId = PythonQtSignalReceiver::getSignalIndex(sender, signal);
   if (sigId >= 0) {

src/PythonQt.h

@@ -727,13 +727,9 @@ class PYTHONQT_EXPORT PythonQtPrivate : public QObject
   PythonQtClassInfo* lookupClassInfoAndCreateIfNotPresent(const char* typeName);
 
   //! add a signal handler
-  //!
-  //! The GIL should be held when calling this
   bool addSignalHandler(QObject* sender, const char* signal, PyObject* callable);
 
   //! remove a signal handler for given callable (or all callables on that signal if callable is NULL)
-  //!
-  //! The GIL should be held when calling this
   bool removeSignalHandler(QObject* sender, const char* signal, PyObject* callable = nullptr);
 
   //! called when a signal receiver is deleted to remove it from the hash map

src/PythonQtSignalReceiver.h

@@ -71,7 +71,7 @@ class PYTHONQT_EXPORT PythonQtSignalTarget
   //! call the python callable with the given arguments (as defined in methodInfo)
   void call(void** arguments) const;
 
-  //! check if it is this targets the same callable
+  //! check if this targets the same callable
   bool isSame(PyObject* callable) const;
 
   //! call the given callable with arguments described by PythonQtMethodInfo, returns a new reference as result value (or NULL)
@@ -109,7 +109,7 @@ class PythonQtSignalReceiver : public PythonQtSignalReceiverBase
   //! Returns the signal ID for which this receiver was created.
   int signalId() const { return _signalId; }
 
-  //! Check if this object targets the same callable given as argument.
+  //! Check if this object targets the callable given as argument.
   bool isSameCallable(PyObject* callable) const;
 
   //! Mark this object as already removed from the global list of signal receivers.