Commit a18d646
committed
fix: track map2loop and loopstructuralvisualisation versions in pyproject.toml instead of version.py
Same fix as the LoopStructural root package: map2loop already had a
static pyproject.toml version but its __init__.py still read from the
now-redundant version.py; loopstructuralvisualisation had a dynamic
pyproject.toml version resolved from its version.py via
tool.setuptools.dynamic. Both now use a static pyproject.toml version
directly, with map2loop's __version__ read via importlib.metadata at
runtime (loopstructuralvisualisation's __init__.py never imported
__version__, so no equivalent change needed there).
Also drops loopstructuralvisualisation's release-please extra-files
entry pointing at the now-deleted version.py.
Done ahead of merging this PR: once merged, the root LoopStructural
release-please component's repo-wide version.py filename search
(a structural side effect of its path being ".", not scoped to a
subdirectory) would otherwise find and try to bump these packages'
version.py files too, colliding with their own release-please
components -- the same bug fixed for loop_interpolation's stray
loopsolver/version.py in #315.1 parent 1823375 commit a18d646
5 files changed
Lines changed: 5 additions & 14 deletions
File tree
- packages
- loopstructural_visualisation
- src/loopstructuralvisualisation
- map2loop/src/map2loop
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
5 | 5 | | |
6 | 6 | | |
7 | 7 | | |
8 | | - | |
| 8 | + | |
9 | 9 | | |
10 | 10 | | |
11 | 11 | | |
| |||
42 | 42 | | |
43 | 43 | | |
44 | 44 | | |
45 | | - | |
46 | | - | |
47 | | - | |
48 | 45 | | |
49 | 46 | | |
50 | 47 | | |
Lines changed: 0 additions & 1 deletion
This file was deleted.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
| 2 | + | |
2 | 3 | | |
3 | 4 | | |
4 | 5 | | |
5 | | - | |
| 6 | + | |
| 7 | + | |
6 | 8 | | |
7 | 9 | | |
8 | 10 | | |
| |||
This file was deleted.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
18 | 18 | | |
19 | 19 | | |
20 | 20 | | |
21 | | - | |
22 | | - | |
23 | | - | |
24 | | - | |
25 | | - | |
26 | | - | |
27 | | - | |
| 21 | + | |
28 | 22 | | |
29 | 23 | | |
30 | 24 | | |
0 commit comments