Axis jog plus and minus do not work

[grandixximo]

#3750 broke the jogging buttons in axis UI

I added a commit in #3746 to address this, let me know if this is acceptable, or I should roll back...

[Sigma1912]

@BsAtHome might want to comment.

[BsAtHome]

Sorry about breaking stuff...

When and how do you get None as input event to the the jog functions? I was not able to produce that locally. Is this a keyboard layout thingy (mine is DK-layout)?

The fix is IMO in the wrong place and would better be done in the wrapper functions than having to be repeated in any and all key handler functions like:

 pressed_keys_list = []
 def key_pressed(ev):
+    if None == ev:
+        return False
     if ev.keysym in pressed_keys_list:
         return True
     pressed_keys_list.append(ev.keysym)
     return False
 
 def key_released(ev):
+    if None == ev:
+        return
     # KeyRelease without KeyPress may happen when a modifier is active when
     # the key is pressed without a KeyPress handler. No KeyPress event is

You should roll back and I'll make a PR. But I really want to know what causes your setup to receive None as key event.

[On a side note: IMO these fixes should go into a separate PR. You don't want to stack everything into one pile.]

[grandixximo]

The None isn't from keyboard events, it comes from mouse clicks on the jog buttons.

In axis.tcl when you click the +/- jog buttons with the mouse while in "Continuous" mode:

bind $_tabs_manual.jogf.jog.jogminus <Button-1> {
    if {[is_continuous]} { jog_minus }
}

The Tcl code calls jog_minus / jog_plus / jog_stop without arguments. The Tcl -> Python bridge then passes no parameter to the Python function, causing the "missing required positional argument" error.

Keyboard jogging works fine because those bindings pass the event object.

To reproduce: set jog increment to "Continuous" and click the +/- buttons with the mouse.

Rolled back so you can do a proper fix in key_pressed/key_released, I also think is more appropriate as you said.

[BsAtHome]

I see! Thanks for the info.

A fix is already made and a PR will follow shortly.

[andypugh]

Fixed by #3758