Skip to content

Client-server communication is insecure #22

Description

@jonnor

The server will happily execute arbitrary commands sent by the client. Just type in rm -rf foo and it will be ran.

There is some 'mitigration' in that the Websocket server will only accept connections from the same IP address. However, it is impossible to safely expose fabmodules over a network, which is one of the major benefits of a web-based system.

Proposed is to only execute a known subset of commands (enforced by server), not arbitrary stuff.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions