Travel - User not redirected to "https://staging.travel.expensify.com/" with existing account

[jponikarchuk]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.2.96-4
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from BrowserStack: https://test-management.browserstack.com/projects/2219752/test-runs/TR-2721/folder/13177079/41237916/1112832869?sort=%2Bidentifier
Email or phone of affected tester (no customers): applausetester+piyoe@applause.expensifail.com
Issue reported by: Applause Internal Team
Bug source: Regression TC Execution
Device used: Windows 11 / Chrome, Samsung Galaxy A52 / Android 14, iPhone 13 / iOS 18.7.1
App Component: Workspace Settings

Action Performed:

Preconditions:

1. User already logged in to an existing expensifail account and has 1 workspace
2. Make sure to clear cache and restart in troubleshoot

Steps:

1. Create a new workspace with USD currency (so, now user has two workspace)
2. Navigate to more feature and toggle on the "Travel" feature
3. Click "Travel" in WS setting
4. Click "Let's go"
5. Set the following Company Address "548 Market St San Francisco, CA 94104, United States"
6. Click Save
7. Verify the user is prompted to accept the Terms and Conditions
8. Check the terms box and click continue

Expected Result:

User is redirected to https://staging.travel.expensify.com/ in a new tab or webview

Actual Result:

Clicking continue is unresponsive, sometimes it response in Android platform but it navigate back to the previous page first. Also it's only works well if user using a new expensifail account and have no workspace before.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari

Screenshots/Videos

1.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @marcaaron (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[OSBotify]

🔍 Investigation Summary

Classification: Frontend bug
Causing PR: #77950 - "Refactored ConfirmModal usage to useConfirmModal" by @abbasifaizan70 (High confidence)
Related Issues: None

Recommendation: REVERT

PR #77950 accidentally removed the policyID parameter from the acceptSpotnanaTerms() API call in TravelTerms.tsx, which causes the backend to fail provisioning travel access for users with existing workspaces. This explains why the issue only occurs with existing accounts that have workspaces, but works fine for new accounts without workspaces.

📋 Detailed Analysis

Evidence

PR #77950 was intended to refactor ConfirmModal usage to useConfirmModal across multiple files. While refactoring TravelTerms.tsx, the PR also removed an unrelated line:

Before PR #77950:

const policyID = route.params.policyID;
// ...
asyncOpenURL(
    acceptSpotnanaTerms(domain, policyID).then((response) => {

After PR #77950:

// policyID line removed
// ...
asyncOpenURL(
    acceptSpotnanaTerms(domain).then((response) => {

The policyID parameter was removed from both the local variable declaration and the acceptSpotnanaTerms() function call.

Root Cause

The Travel Terms acceptance flow requires the policyID to properly provision the workspace for travel access in the backend. When policyID is missing:

1. Users with existing workspaces cannot complete the travel enablement flow because the backend cannot determine which workspace to provision
2. New users without workspaces may work because the backend can infer a default workspace
3. The "Continue" button becomes unresponsive or navigates back because the API call fails to return a valid spotnanaToken

The issue description confirms this pattern: "it's only works well if user using a new expensifail account and have no workspace before" - this is exactly the symptom of a missing policyID parameter.

Why This Happened

This appears to be an accidental deletion during the refactoring process. The PR was focused on converting modal usage, but the policyID removal was unrelated to that work and likely happened during code cleanup or merge conflict resolution.