Merge pull request #55 from TheGuitarleader/feature/gui

Checksum generation is now during pushes to improve performance

Author: TheGuitarleader

Parallel.Core/Diagnostics/IProgressReporter.cs

@@ -11,7 +11,8 @@ public enum ProgressOperation
         Pushed,
         Synced,
         Downloading,
-        Uploading
+        Uploading,
+        Hashing
     }
 
     /// <summary>

Parallel.Core/IO/Scanning/FileScanner.cs

@@ -9,6 +9,7 @@
 using Parallel.Core.Database;
 using Parallel.Core.IO.Syncing;
 using Parallel.Core.Models;
+using Parallel.Core.Security;
 using Parallel.Core.Settings;
 using Parallel.Core.Utils;
 using FileInfo = System.IO.FileInfo;
@@ -98,6 +99,7 @@ public async Task<SystemFile[]> GetFileChangesAsync(string path, string[] ignore
         /// <returns>True is success, otherwise false.</returns>
         public static bool HasChanged(SystemFile sourcePath, SystemFile? targetPath)
         {
+            if (string.IsNullOrEmpty(sourcePath.CheckSum)) sourcePath.TryGenerateCheckSum();
             return targetPath == null || (sourcePath.LastWrite.TotalMilliseconds > targetPath.LastWrite.TotalMilliseconds && Convert.ToBoolean(!sourcePath.CheckSum?.Equals(targetPath.CheckSum)));
         }
 

Parallel.Core/IO/Syncing/FileSyncManager.cs

@@ -5,6 +5,7 @@
 using Parallel.Core.Database;
 using Parallel.Core.Diagnostics;
 using Parallel.Core.Models;
+using Parallel.Core.Security;
 using Parallel.Core.Settings;
 using Parallel.Core.Utils;
 
@@ -36,13 +37,14 @@ public override async Task<int> PushFilesAsync(SystemFile[] files, IProgressRepo
             Task worker = System.Threading.Tasks.Parallel.ForEachAsync(uploadFiles, ParallelConfig.Options, async (file, ct) =>
             {
                 Interlocked.Increment(ref queued);
-                SemaphoreSlim lockedThread = threadPool.GetOrAdd(file.CheckSum, _ => new SemaphoreSlim(1, 1));
+                if (string.IsNullOrEmpty(file.CheckSum) && !file.TryGenerateCheckSum()) return;
+                SemaphoreSlim lockedThread = threadPool.GetOrAdd(file.CheckSum!, _ => new SemaphoreSlim(1, 1));
                 await lockedThread.WaitAsync(ct);
 
                 try
                 {
                     Log.Debug($"Pushing -> {file.LocalPath}");
-                    file.RemotePath = PathBuilder.GetObjectPath(RemoteVault, file.CheckSum);
+                    file.RemotePath = PathBuilder.GetObjectPath(RemoteVault, file.CheckSum!);
                     long result = await StorageProvider.UploadFileAsync(file, false, ct);
                     if (result <= 0)
                     {
@@ -63,7 +65,7 @@ public override async Task<int> PushFilesAsync(SystemFile[] files, IProgressRepo
                 finally
                 {
                     lockedThread.Release();
-                    threadPool.TryRemove(file.CheckSum, out _);
+                    threadPool.TryRemove(file.CheckSum!, out _);
                     Interlocked.Increment(ref completed);
                     Interlocked.Decrement(ref queued);
                 }
@@ -101,7 +103,8 @@ public override async Task<int> PullFilesAsync(SystemFile[] files, IProgressRepo
             Task worker = System.Threading.Tasks.Parallel.ForEachAsync(files, ParallelConfig.Options, async (file, ct) =>
             {
                 Interlocked.Increment(ref queued);
-                SemaphoreSlim lockedThread = threadPool.GetOrAdd(file.CheckSum, _ => new SemaphoreSlim(1, 1));
+                if (string.IsNullOrEmpty(file.CheckSum) && !file.TryGenerateCheckSum()) return;
+                SemaphoreSlim lockedThread = threadPool.GetOrAdd(file.CheckSum!, _ => new SemaphoreSlim(1, 1));
                 await lockedThread.WaitAsync(ct);
 
                 try
@@ -131,7 +134,7 @@ public override async Task<int> PullFilesAsync(SystemFile[] files, IProgressRepo
                 finally
                 {
                     lockedThread.Release();
-                    threadPool.TryRemove(file.CheckSum, out _);
+                    threadPool.TryRemove(file.CheckSum!, out _);
                     Interlocked.Increment(ref completed);
                     Interlocked.Decrement(ref queued);
                 }

Parallel.Core/Models/Manifest.cs

@@ -1,6 +1,7 @@
 // Copyright 2025 Kyle Ebbinga
 
 using System.Data;
+using System.Security.Cryptography;
 using Parallel.Core.Data;
 using Parallel.Core.Diagnostics;
 using Parallel.Core.Security;
@@ -71,7 +72,7 @@ public class SystemFile
         /// <summary>
         /// The checksum used to check if the file has changed.
         /// </summary>
-        public string CheckSum { get; } = string.Empty;
+        public string? CheckSum { get; set; } = string.Empty;
 
 
         /// <summary>
@@ -89,7 +90,6 @@ public SystemFile(string path)
             Type = FileTypes.GetFileCategory(Path.GetExtension(fileInfo.Name));
             Hidden = fileInfo.Attributes.HasFlag(FileAttributes.Hidden);
             ReadOnly = fileInfo.Attributes.HasFlag(FileAttributes.ReadOnly);
-            CheckSum = HashGenerator.CheckSum(path) ?? string.Empty;
             Deleted = !fileInfo.Exists;
         }
 
@@ -166,5 +166,27 @@ public bool Equals(SystemFile value)
 
             return results.All(b => b != null && (bool)b);
         }
+
+        public bool TryGenerateCheckSum()
+        {
+            // Ignore if already valid.
+            if (!string.IsNullOrEmpty(CheckSum)) return true;
+
+            try
+            {
+                Log.Debug($"Generating checksum -> {LocalPath}");
+                if (!File.Exists(LocalPath)) return false;
+
+                using SHA256 sha256 = SHA256.Create();
+                using FileStream fs = File.OpenRead(LocalPath);
+                CheckSum = Convert.ToHexStringLower(sha256.ComputeHash(fs));
+                return !string.IsNullOrEmpty(CheckSum);
+            }
+            catch (Exception ex)
+            {
+                Log.Error(ex, $"Checksum generation failed -> {LocalPath}");
+                return false;
+            }
+        }
     }
 }

Parallel.Core/Models/SystemFile.cs

@@ -96,18 +96,5 @@ public static string CreateSHA256(string value)
             ArgumentException.ThrowIfNullOrEmpty(value);
             return Convert.ToHexString(SHA256.HashData(Encoding.UTF8.GetBytes(value))).ToLower();
         }
-
-        /// <summary>
-        ///
-        /// </summary>
-        /// <param name="path"></param>
-        /// <returns></returns>
-        public static string? CheckSum(string path)
-        {
-            if (!File.Exists(path)) return null;
-            using FileStream fs = File.OpenRead(path);
-            using SHA256 sha256 = SHA256.Create();
-            return Convert.ToHexStringLower(sha256.ComputeHash(fs));
-        }
     }
 }