Refactor recording option tests

Reworked tests to match the split between base WriteGear option construction and config-level overrides. Added focused unit coverage for `build_writegear_options` (default values, FPS fallback, invalid FPS handling, and override merging), updated `RecordingSettings` tests to validate `writegear_overrides()` behavior by codec/fast-encoding mode, and relaxed GUI manager assertions to only check override-specific flags.

Author: C-Achard

tests/gui/test_rec_manager.py

@@ -471,8 +471,6 @@ def test_start_all_passes_writegear_options(
 
             opts_ovrr = rec.writer_options_overrides
             assert opts_ovrr is not None
-            assert opts_ovrr["-vcodec"] == "libx264"
-            assert opts_ovrr["-crf"] == "23"
             assert opts_ovrr["-preset"] == "ultrafast"
             assert opts_ovrr["-tune"] == "zerolatency"
     finally:

tests/services/test_video_recorder.py

@@ -9,6 +9,7 @@
 import pytest
 
 import dlclivegui.services.video_recorder as vr_mod
+from dlclivegui.config import DEFAULT_RECORDING_FPS
 from dlclivegui.utils.timestamps import FrameTimestampMetadata
 
 # ----------------------------
@@ -528,3 +529,63 @@ def test_stop_writes_hardware_timestamp_metadata_sidecar_json(
             "raw_value": 1_000_000,
         }
         assert rec0["hardware_timestamp_default"] == 0.001
+
+
+def test_build_writegear_options_default():
+    opts = vr_mod.build_writegear_options(
+        frame_rate=100.0,
+        codec="libx264",
+        crf=23,
+    )
+
+    assert opts == {
+        "-input_framerate": 100.0,
+        "-vcodec": "libx264",
+        "-crf": 23,
+    }
+
+
+def test_build_writegear_options_invalid_fps_uses_default():
+    opts = vr_mod.build_writegear_options(
+        frame_rate=0.0,
+        codec="libx264",
+        crf=23,
+    )
+
+    assert opts["-input_framerate"] == DEFAULT_RECORDING_FPS
+
+
+@pytest.mark.parametrize(
+    "frame_rate",
+    [None, 0, -1, "invalid"],
+)
+def test_build_writegear_options_unusable_fps_uses_default(
+    frame_rate,
+):
+    opts = vr_mod.build_writegear_options(
+        frame_rate=frame_rate,
+        codec="libx264",
+        crf=23,
+    )
+
+    assert opts["-input_framerate"] == DEFAULT_RECORDING_FPS
+
+
+def test_build_writegear_options_merges_overrides():
+    opts = vr_mod.build_writegear_options(
+        frame_rate=100.0,
+        codec="libx264",
+        crf=23,
+        overrides={
+            "-preset": "ultrafast",
+            "-tune": "zerolatency",
+        },
+    )
+
+    assert opts == {
+        "-input_framerate": 100.0,
+        "-vcodec": "libx264",
+        "-crf": 23,
+        "-preset": "ultrafast",
+        "-tune": "zerolatency",
+    }

tests/test_config.py

@@ -76,43 +76,47 @@ def test_trigger_source_defaults_to_auto():
     assert trigger.source == "auto"
 
 
-def test_recording_settings_writegear_options_default():
-    settings = RecordingSettings(codec="libx264", crf=23, fast_encoding=False)
-
-    opts = settings.writegear_options(100.0)
-
-    assert opts["-input_framerate"] == 100.0
-    assert opts["-vcodec"] == "libx264"
-    assert opts["-crf"] == "23"
-    assert "-preset" not in opts
-    assert "-tune" not in opts
-
-
-def test_recording_settings_writegear_options_fast_encoding_x264():
-    settings = RecordingSettings(codec="libx264", crf=23, fast_encoding=True)
+def test_recording_settings_writegear_overrides_default():
+    settings = RecordingSettings(
+        codec="libx264",
+        crf=23,
+        fast_encoding=False,
+    )
 
-    opts = settings.writegear_options(100.0)
+    assert settings.writegear_overrides() == {}
 
-    assert opts["-input_framerate"] == 100.0
-    assert opts["-vcodec"] == "libx264"
-    assert opts["-crf"] == "23"
-    assert opts["-preset"] == "ultrafast"
-    assert opts["-tune"] == "zerolatency"
 
+def test_recording_settings_writegear_overrides_fast_encoding_x264():
+    settings = RecordingSettings(
+        codec="libx264",
+        crf=23,
+        fast_encoding=True,
+    )
 
-def test_recording_settings_writegear_options_fast_encoding_nvenc_no_x264_options():
-    settings = RecordingSettings(codec="h264_nvenc", crf=23, fast_encoding=True)
+    assert settings.writegear_overrides() == {
+        "-preset": "ultrafast",
+        "-tune": "zerolatency",
+    }
 
-    opts = settings.writegear_options(100.0)
 
-    assert opts["-vcodec"] == "h264_nvenc"
-    assert "-preset" not in opts
-    assert "-tune" not in opts
+def test_recording_settings_writegear_overrides_fast_encoding_x265():
+    settings = RecordingSettings(
+        codec="libx265",
+        crf=23,
+        fast_encoding=True,
+    )
 
+    assert settings.writegear_overrides() == {
+        "-preset": "ultrafast",
+        "-tune": "zerolatency",
+    }
 
-def test_recording_settings_writegear_options_invalid_fps_falls_back_to_30():
-    settings = RecordingSettings(codec="libx264", crf=23)
 
-    opts = settings.writegear_options(None)
+def test_recording_settings_writegear_overrides_nvenc():
+    settings = RecordingSettings(
+        codec="h264_nvenc",
+        crf=23,
+        fast_encoding=True,
+    )
 
-    assert opts["-input_framerate"] == 30.0
+    assert settings.writegear_overrides() == {}